-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glob #392
base: main
Are you sure you want to change the base?
Glob #392
Conversation
…them. print-rdf returns the correct combined document.
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 79.29% 69.90% -9.39%
==========================================
Files 18 16 -2
Lines 3260 2911 -349
Branches 879 766 -113
==========================================
- Hits 2585 2035 -550
- Misses 442 677 +235
+ Partials 233 199 -34
Continue to review full report at Codecov.
|
Added multiple document support and globbing. Also added a PubSeq test. Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pjotrp !
Can you run make format
and then check the output of make flake8
?
Please run make diff_pydocstyle_report
as shown above and fix the complaint :-)
Looks like the MANIFEST.in
needs updating..
Feel free to run tox
as the CI tests stopped once the first error was reached.
Will fix. Are you OK with the test data hosted in test/data/pubseq? |
I can't think of a reason not to be. What's the total size? We install our tests so users can verify post installation - (via pip, apt, whatever) |
Ping :-) |
On my todo list. Probably end of July because of holiday and other things. |
Globbing multiple documents.
Later we may need to add chunking when these documents take all RAM.