Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the rest of the distributed-haskell packages #7563

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

davidsd
Copy link
Contributor

@davidsd davidsd commented Nov 3, 2024

I have been able to manually build all the packages with the latest snapshot. However, verify-package doesn't work because the packages being added are interdependent.

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@davidsd
Copy link
Contributor Author

davidsd commented Nov 4, 2024

The tests failed because of a version number issue with distributed-process-test. I'm working on a fix: haskell-distributed/distributed-process#461

@davidsd
Copy link
Contributor Author

davidsd commented Nov 4, 2024

Ok, the version number problem should be fixed. Please re-run tests.

@mihaimaruseac mihaimaruseac merged commit 0707f2d into commercialhaskell:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants