Argocd diff #4
Merged
Argocd diff #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn on failure to find apps
Improved formating in failure cases
Document env var default values
Remove dead code
Named return value in multiple function
Renaming/spliting of some vars
Switched from map[relevantComponent]bool) to desribe a set map[relevantComponent]struct{})
Add some error handeling Document some functions
Co-authored-by: Yazdan Mohammadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optionally add ArgoCD "diff" comment on PRs
Light refactoring of the promotion logic to allow ArgoCD functionality to re-use of generateListOfRelevantComponents
re-applying PR #3 after a failed to squash it :)
Type of Change
Checklist