upgrade secp256kfun

[delta1]

re: #1459

upgrades the secp256kfun dependency, the previously pinned version fails to compile on rust 1.74

fixes a few resulting issues, and some minor cleanup refactoring

also adds a new CI job to run cargo check on rust stable

also closes:

• build(deps): bump sigma_fun from 9657d8c to 296fd6f #1410
• build(deps): bump ecdsa_fun from 9657d8c to 296fd6f #1412

[binarybaron]

I will need some time to review this as this is quite critical code and I'm not too familiar with the library.

[ikmckenz]

Out of curiosity, why resolve on 0.24.1 instead of the most recent release (0.28)?

[delta1]

Out of curiosity, why resolve on 0.24.1 instead of the most recent release (0.28)?

looks like you’re referring to secp256k1, this PR is upgrading secp256kfun. as for the versions, from the lockfile it looks like bitset still has a dependency on 0.24 of secp256k1, and secp256kfun is still depending on 0.27 of secp256k1

[binarybaron]

LGTM but have you completed a swap using the new CLI version and an old ASB version yet?

[delta1]

LGTM but have you completed a swap using the new CLI version and an old ASB version yet?

no i have not

[delta1]

updated to include #1546 #1547

[delta1]

updated to include #1549 #1550

[delta1]

update to include #1556 and #1557

also sets the revision in the Cargo.toml manifest

[binarybaron]

Is this 100% backwards compatible in terms of the database and p2p protocols?

[delta1]

@ikmckenz if you have a moment, please test this by building this branch asb/swap, and use those binaries on testnet performing a swap against the previous version

[delta1]

Sigh I don't have any testnet bitcoin to test with 😩 @binarybaron any donations?

tb1qttry3wfcwcf7gyv26a5elt9hcran7nsnfj9zgj

[delta1]

Is this 100% backwards compatible in terms of the database and p2p protocols?

tested a number of testnet swaps between this version of asb and latest swap release, as well as this version of swap with latest asb release

happy for this change to be a version change to 0.13

[binarybaron]

No need. I'll trust you on that.

[binarybaron]

bors r+

[linsui]

Why do you use the git repo instead of 0.10.0 on crates.io?

[delta1]

Why do you use the git repo instead of 0.10.0 on crates.io?

good question, i think that’s a hangover from where we were ahead of their releases to crates.io

i’m going to rework this PR to use the crates version, thanks for the suggestion

[binarybaron]

LGTM!

[delta1]

includes a fix for #1645