Updates for newer versions of Ruby and Rails #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like they were introduced in 2.4 and make the code easier to read.
The big one was `--skip-asset-pipeline` which replaces `--skip-sprockets`.
While we probably support older versions of Ruby and Rails there is little point in testing against anything that is end of life.
Rails 8.0 requires Ruby 3.2 or newer
Older versions of interactor-rails should still be compatible with older versions of Ruby and Rails. This is mainly a change to constrain how much testing and support we need to do by removing all end-of-life versions.
The only code that interactor-rails uses is to hook into generators. I'd be surprised if someone was using railties without Rails but this does reduce our dependency to only the code we need. Closes #34
At one point rspec advised splitting helpers between rails_helpers and spec_helpers. The general idea was that code which didn't depend on Rails itself (like testing plain old Ruby objects) could be run faster by depending on spec_helpers which required less code. Closes #33
Rails 3.x is no longer officially supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.