Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional context #736

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amkisko
Copy link

@amkisko amkisko commented Oct 29, 2024

Done:

  • updated README with additional instructions
  • implemented context storage and merging before audit record writing
  • implemented test coverage for changed parts
  • updated generators and templates

Background:

  • comment:string is not enough for storing and accessing additional context
  • known approach is to have separate column with additional serialized data
  • would be nice to avoid context storage on auditable record
  • would be nice to have global setter to add context once per request/job
  • should be always optional to add more context

References:

@amkisko
Copy link
Author

amkisko commented Nov 11, 2024

This one requires improvement, I completely missed the point that audited_changes is stored as text. context should be same for better support.

@amkisko
Copy link
Author

amkisko commented Nov 11, 2024

@danielmorrison fixes pushed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant