[add] exhibit namespaces makes chameleon happy. addresses #1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoinea
added a commit
that referenced
this pull request
Jan 9, 2013
[add] exhibit namespaces makes chameleon happy. addresses #1
|
This breaks the view when using without chameleon https://gist.github.com/654d0fa158da499aade2 |
| <tal:facet define=" | ||
| name python:view.gett('name', ''); | ||
| label python:view.gett('label', '');"> | ||
| <tal:block xmlns:ex="http://simile.mit.edu/2006/11/exhibit#"> |
There was a problem hiding this comment.
It doesn't seems to work: https://gist.github.com/654d0fa158da499aade2
|
I think it doesn't work with the "tal" element, it seems to work ok with div and other HTML elements. I just pushed a quick fix in eea.app.visualization and eea.exhibit. Can you please check if this is ok for chameleon? Thank you |
|
I confirm, it works :) Sorry for the inconvenient :P |
|
:) Don't worry. Can you please also drop a line in HISTORY.txt with your changes? Same for eea.exhibit. Thanks |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.