Split src/colis.ml into a library and an executable

[Niols]

• It makes the separation of code cleaner
• It allows for an easy use of internal functions (eg for testing purpose)
• It allows for a better documentation of internal functions
• It will allow an other tool to use the internal library directly instead of using the executable

[benozol]

What about showing the same error message for syntax errors in Shell (Morsmall.SyntaxError) and Colis (Colis.ColisParser)? (BTW it would be nice if we could have a pos for the Colis parser as well and display it. I’ll have a look later…)

[Niols]

I agree. If fact, in the lib Colis, we could have only one exception for all lexing/parsing errors, what do you think? And indeed, it would be nice to carry a position in the parser (which reminds me of #19: do we want positions in the AST?)

[benozol]

only one exception for all lexing/parsing errors

Yes good idea.

#19

It will certainly be interesting to be able to point to the position in the shell script from within the symbolic execution. But IMO we can postpone adding positions to the AST until we are there – it will require refactoring but won’t be technically complicated. What do you think?

[Niols]

only one exception for all lexing/parsing errors

Yes good idea.

OK, commit inc

#19

It will certainly be interesting to be able to point to the position in the shell script from within the symbolic execution. But IMO we can postpone adding positions to the AST until we are there – it will require refactoring but won’t be technically complicated. What do you think?

So at some point we will refactor both the AST, the conversion and the parser to add positions everywhere? Fine with me

[benozol]

Very useful PR – I was already alienated by how much logic should be put into the colis.ml.

[benozol]

OK looks good to me!

[Niols]

Do you think we should merge it?

[benozol]

Definitely