Add is email receipt as doPayment parameter

[francescbassas]

Overview

This little modification allows transfer if the Webform takes care of sending the receipt to doPayment function.

This can allow, for example, payment gateways like Redsys to decide whether to manage the sending of receipts or delegate it to the webform.

[jitendrapurohit]

Can we simply use

$params['is_email_receipt'] = wf_crm_aval($this->data, "receipt:number_number_of_receipt", FALSE);

instead of sending $isEmailReceipt as a param argument?

[francescbassas]

Sure! Like this? #987

[mattwire]

The problem with this is that it's completely unsupported to pass in a parameter for email receipt to doPayment(). I'm not actually aware of any payment processors that would support that?

I do understand that there is a problem to solve - we can set email_receipt on contribution_page or contribution_recur but not on the contribution itself but I think that needs to be solved in CiviCRM first.
Also, the receipt would not usually be sent from within doPayment() as it would be handled when recording the payment which would be done when the IPN code is invoked.

I think we'd need support for a receipt parameter in CiviCRM first (maybe an additional field in civicrm_contribution that could be set?).

[francescbassas]

Thanks @mattwire

With this, I'm trying to resolve the Redsys payment processor casuistry when its IPN it's invoked. The idea with the change is that the payment processor can distinguish when the webform is already managing the sending of the receipt and, therefore, not send the one that is enabled by default. I don't know if there is any other payment processor that could also benefit.

cc @sluc23