Skip to content

Commit

Permalink
Added some comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
broneill committed Oct 3, 2024
1 parent 2ff7bdc commit f0f0f0c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions src/main/java/org/cojen/dirmi/core/Item.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
* Base class for objects which are associated with an identifier. They can be stored within a
* single ItemMap instance.
*
* <p>This class is subclassed by Stub and so it must not declare any new public instance
* methods because they can conflict with user-specified remote methods which have the same
* signature.
*
* @author Brian S O'Neill
* @see ItemMap
* @see IdGenerator
Expand Down
6 changes: 5 additions & 1 deletion src/main/java/org/cojen/dirmi/core/Stub.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
import org.cojen.dirmi.Remote;

/**
* Base class for remote stubs.
* Base class for remote stubs. It must not declare any new public instance methods because
* they can conflict with user-specified remote methods which have the same signature.
*
* @author Brian S O'Neill
*/
Expand Down Expand Up @@ -69,6 +70,9 @@ public Stub(long id, StubSupport support, MethodIdWriter miw) {
/**
* Returns true if this stub is restorable following a disconnect.
*
* Note: This method must not be public or else it can conflict with a user-specified
* remote method which has the same signature.
*
* @see #setRootOrigin
*/
final boolean isRestorable() {
Expand Down
1 change: 0 additions & 1 deletion src/main/java/org/cojen/dirmi/core/StubMaker.java
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ private void writeParams(MethodMaker mm, Variable pipeVar,
writeName = "writeSyntheticMethodId";
}


mm.field("miw").getAcquire().invoke(writeName, pipeVar, methodId, method.name());

if (ptypes.length <= 0) {
Expand Down

0 comments on commit f0f0f0c

Please sign in to comment.