Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About page #264

Merged
merged 4 commits into from
Oct 5, 2023
Merged

About page #264

merged 4 commits into from
Oct 5, 2023

Conversation

MarkTallentire
Copy link
Contributor

@MarkTallentire MarkTallentire commented Oct 5, 2023

Added menu as per #29

Do we have any content written for other sections?
Comparing to Aoe4world they have quite a bit of content under each section whereas right now we only have a basic about page for the site itself, added some placeholder tabs for now so you can see the current design but if we have some content I can add that.

Screenshot 2023-10-05 at 10 53 13

@MarkTallentire
Copy link
Contributor Author

Also just realised that the original request was for it to Anchor and Scroll, let me know if you're happy with it switching the way it does or if you want it changed to auto scrolling anchors.

@petrvecera
Copy link
Member

Hi, thanks for the submission. As you said I do have some text which I would like to write on that page but it's not that much. So that's also the reason why I wanted to have it more on one page, with some scrolls and anchors. I am afraid that for tabs it's not enough content.

Would you be able to do it like that?

Thank you 🙏

@MarkTallentire
Copy link
Contributor Author

Updated to Anchors and scrolling

@petrvecera
Copy link
Member

Nice 👍 I am gonna add the texts on master. Thank you 🙏

@petrvecera petrvecera merged commit e027c81 into cohstats:master Oct 5, 2023
3 of 4 checks passed
@MarkTallentire MarkTallentire deleted the About-Page branch October 5, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants