Add extra text formatter to abilities and upgrades #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🌐 Branch deployed as preview to: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | https://preview.coh3stats.com |
| Device | URL |
|---|---|
| mobile | https://preview.coh3stats.com |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
petrvecera
reviewed
Oct 5, 2023
| helpText: string; | ||
| briefText: string; | ||
| screenName: string; | ||
| extraText: string; // Could be empty (Set as $0). |
There was a problem hiding this comment.
This is one thing I am not sure about.
I added these checks that if it's null it should not be displayed, so we can be sure what
if("") is false, so it's going to work, but it's something we can think off how to handle across the app.
There was a problem hiding this comment.
Yeah, it does work without issues for both null or empty string checks. :)
|
Nice 👍 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.