Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve about page #29

Closed
petrvecera opened this issue Feb 25, 2023 · 4 comments
Closed

Improve about page #29

petrvecera opened this issue Feb 25, 2023 · 4 comments
Assignees
Labels
free-to-grab For anyone who wants to take it.

Comments

@petrvecera
Copy link
Member

About page should be on url /about

It should be one page with sections for more things - similar what we have on https://coh2stats.com/about

But it should have table of contents on the side, similar what is here https://aoe4world.com/faq#leaderboard

The content of the page can be populated later

@petrvecera
Copy link
Member Author

We still need to clean up the about page and add table of contents there

@petrvecera petrvecera changed the title Add about page Improve about page Mar 4, 2023
@petrvecera petrvecera added the free-to-grab For anyone who wants to take it. label Mar 13, 2023
@MarkTallentire
Copy link
Contributor

Hi @petrvecera.

I should be able to start work on this today. Just dropping a note in case anyone else is working on it.

Mark

@petrvecera
Copy link
Member Author

Hi @MarkTallentire, awesome.

Basically this task is just about making that menu, which would scroll you on that page.
Everything for the about page is here https://github.com/cohstats/coh3-stats/blob/master/pages/about.tsx

Let me know if you have any questions :)

@petrvecera
Copy link
Member Author

@MarkTallentire Thank you a lot for your MR. Your approach is great! ❤️

I added more content and just moved the files little bit #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
free-to-grab For anyone who wants to take it.
Projects
None yet
Development

No branches or pull requests

2 participants