Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorten GPU_DEVICE_SELECT -> GPU_DEVICE; use custom adapter selection logic again #1403

Merged
merged 6 commits into from
Dec 25, 2024
Merged

shorten GPU_DEVICE_SELECT -> GPU_DEVICE; use custom adapter selection logic again #1403

merged 6 commits into from
Dec 25, 2024

Conversation

rcoreilly
Copy link
Member

No description provided.

kkoreilly
kkoreilly requested changes Dec 25, 2024
View reviewed changes
Copy link
Member

@kkoreilly kkoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add printing of the default GPU device to webgpuinfo, in addition to a statement explaining that you can use the GPU_DEVICE environment variable to change it.

gpu/gpu.go Outdated Show resolved Hide resolved
kkoreilly
kkoreilly requested changes Dec 25, 2024
View reviewed changes
gpu/gpu.go Outdated Show resolved Hide resolved
gpu/cmd/webgpuinfo/main.go Show resolved Hide resolved
@kkoreilly kkoreilly changed the title shorten GPU_DEVICE_SELECT -> GPU_DEVICE shorten GPU_DEVICE_SELECT -> GPU_DEVICE; use custom adapter selection logic again Dec 25, 2024
@kkoreilly kkoreilly merged commit 0a17ddf into main Dec 25, 2024
1 check passed
@kkoreilly kkoreilly deleted the gpudev branch December 25, 2024 20:15
@kkoreilly kkoreilly mentioned this pull request Dec 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkoreilly kkoreilly kkoreilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcoreilly @kkoreilly