feat: add hash to reply in article detail page #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
commented
Dec 21, 2024
MrOrz
reviewed
Dec 22, 2024
Comment on lines
+46
to
+50
| useEffect(() => { | ||
| if (anchorRef.current.hash === location.hash) { | ||
| anchorRef.current.scrollIntoView({ behavior: 'smooth' }); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
Personally I prefer scroll-behavior CSS than imperative JS scrolling. I think it's OK to apply scroll-behavior globally
| ref={anchorRef} | ||
| className={classes.hash} | ||
| href={`#${articleReply.replyId}`} | ||
| onClick={e => e.target.scrollIntoView({ behavior: 'smooth' })} |
There was a problem hiding this comment.
scrollIntoView is probably not needed if we define a global scroll-behavior in CSS.
However, it would be nice if clicking # copies the URL + href into clipboard. We are already using copy-to-clipboard package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #348
This PR adds a hash symbol after each reply summary, scroll into view on click or on page load.