Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show login modal when anonymous user clicks on comment btn #591

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Dec 21, 2024

fix #277

This PR changes to show the login modal when the user is not logged in and the user wants to comment on an article.

I have done this with React Context instead of prop drilling.
I am not quite familiar with React, please let me know it there are any changes needed.

@coveralls
Copy link

Coverage Status

coverage: 71.733%. remained the same
when pulling 07086fc on ydcjeff:issue-277
into d5a4be4 on cofacts:master.

Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, let's try it out on staging

@MrOrz MrOrz merged commit ed528ce into cofacts:master Dec 22, 2024
2 checks passed
@ydcjeff ydcjeff deleted the issue-277 branch December 23, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block anonymous user from clicking "Reply to this message" and "Comment" button
3 participants