Support for .url() on InMemoryStorage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need @SeanHayes changes in order to continue using this module. Is it possible to merge the Pull request and include that in the package installed with Pip? |
|
The |
pipermerriam
pushed a commit
to pipermerriam/django-inmemorystorage
that referenced
this pull request
Oct 23, 2014
Add more specific Python version classifiers to setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes which let you access the ".url" property of models.FileFields without an exception being thrown. Though the URLs aren't actually accessible, the lack of exceptions does allow for InMemoryStorage to be used as a mock storage object during testing.