Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Formatters #26

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Custom Formatters #26

merged 6 commits into from
Sep 21, 2023

Conversation

geoffreywiseman
Copy link
Contributor

Taking the PR (#25) from @kim0 and expanding on it.

I wanted to be able to more easily test the formatters we have so far and make it easy to add more formatters later.

kim0 and others added 2 commits September 20, 2023 19:24
Taking the PR from @kim0 and expanding on it.

I wanted to be able to more easily test the formatters we have so far and make it easy to add more formatters later.

[#7]

Signed-off-by: Geoffrey Wiseman <[email protected]>
Copy link
Contributor

@kim0 kim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! Thanks for taking this to the next level

Looks like the `—skip` flag didn’t survive the formatter refactoring:
- Added filtering outside of formatting
- Added support for 0-workflow repos to TSV formatter
- Changed the way 0-workflow repos display on the human formatter
- Added tests for the empty case to both formatters

Signed-off-by: Geoffrey Wiseman <[email protected]>
Signed-off-by: Geoffrey Wiseman <[email protected]>
Signed-off-by: Geoffrey Wiseman <[email protected]>
Signed-off-by: Geoffrey Wiseman <[email protected]>
@geoffreywiseman geoffreywiseman merged commit 2117caa into main Sep 21, 2023
@geoffreywiseman geoffreywiseman deleted the feature/formatters branch September 21, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants