Handle URLs properly #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
OK, yeah, this is needed. I'm a bit worried about diverging too much from the upstream yaml2ics (link at the top) and if we should try to sends all these changes upstream there. That had been my idea but maybe we should split and accept we will diverge too much (I'm not sure how much further upstream would want to go). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update downloads the ics calendars (also from urls which are not ending in ics (quite common e.g. enccs), determines file extensions from the headers (or filename if no headers provided) and adds the events.
With a little more code, additional file types from URLs can be added easily.