Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ヘッダーに検索機能を再追加 #972

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

yuki384
Copy link
Member

@yuki384 yuki384 commented Sep 30, 2020

close #912
Kata の検索機能をヘッダーに再度追加しました。
検索アイコンをクリックで検索バーを表示できます

kata-search

やらないこと

  • モバイル版での検索機能追加

@yasulab yasulab temporarily deployed to coderdojo-pi-add-search-v6xfej September 30, 2020 03:45 Inactive
@yuki384 yuki384 force-pushed the add-search-icon-to-header branch from a2897d3 to bb7e808 Compare September 30, 2020 03:47
@yuki384 yuki384 temporarily deployed to coderdojo-pi-add-search-v6xfej September 30, 2020 03:48 Inactive
@yasulab
Copy link
Member

yasulab commented Sep 30, 2020

早速の PR ありがとうございます!😻🆒✨

落ちているテストは master で修正済みのものだと思うので、こちら一旦マージしちゃいますね 🛠💨✨

@yasulab yasulab merged commit e1d668d into master Sep 30, 2020
@yasulab yasulab deleted the add-search-icon-to-header branch September 30, 2020 04:26
yasulab added a commit that referenced this pull request Sep 30, 2020
@yasulab
Copy link
Member

yasulab commented Sep 30, 2020

検索機能のモバイル対応は別 Issue に切り出しておきました! 📝 💨 #973

yasulab added a commit that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔍 グローバルヘッダーに検索機能を再追加する
2 participants