Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jun 10, 2024
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <html lang="ko"> | |||
Comment on lines
+5
to
+9
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta property="og:title" content="판다마켓" /> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="https://aesthetic-fox-bd5eb6.netlify.app" /> | ||
| <meta property="og:description" content="일상의 모든 물건을 거래해 보세요" /> |
| @@ -18,69 +25,71 @@ | |||
| <section id="topBannerPanda" class="banner"> | |||
| <div class="limited-width"> | |||
| <h1> | |||
| 일상의 모든 물건을<br> | |||
| 일상의 모든 물건을<br /> | |||
| <span class="contentSmolText">Hot item</span> | ||
| <h1>인기 상품을<br>확인해 보세요</h1> | ||
| <h2>Hot item</h2> | ||
| <h1>인기 상품을 <span class="break-on-desktop"><br /></span>확인해 보세요</h1> |
There was a problem hiding this comment.
클래스명도 새롭게 수정해주셨네요! 저번에 말씀드렸던 다른 css 방법론에 대해서 알아보시고 적용해보시는 것도 추천드려요!
| <div class="topBigLogo"> | ||
| <a href="/"><img class="topBigLogoImg" src="img/top_big_logo.png" alt="판다마켓"></a> | ||
| </div> | ||
| <a href="/" class="topBigLogo"><img class="topBigLogoImg" src="img/top_big_logo.png" alt="판다마켓"></a> |
There was a problem hiding this comment.
여긴 아직 class 명이 수정되지 않았네요!
| } | ||
|
|
||
| footer { | ||
| padding: 32px 104px 108px 104px; |
There was a problem hiding this comment.
left와 right 값이 같을때 padding: 32px 104px 108px; 이런식으로도 작성 가능합니다!
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>판다마켓_회원가입</title> | ||
| <link rel="stylesheet" as="style" crossorigin | ||
| href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/static/pretendard.min.css"> | ||
| <link rel="stylesheet" href="sign.css"> | ||
| <link rel="stylesheet" href="media.css"> |
There was a problem hiding this comment.
link 태그에도 닫는 표시 해주시면 좋을 것 같습니다.
-media.css의 141~143번째 줄의 코드가 먹히지 않는 것 같은데, 원인이 무엇인지 모르겠습니다.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
랜딩 페이지
###심화
###배포주소
https://aesthetic-fox-bd5eb6.netlify.app/
멘토에게
-media.css의 141~143번째 줄의 코드가 먹히지 않는 것 같은데, 원인이 무엇인지 모르겠습니다.