Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaewan0
added
매운맛🔥
201steve
reviewed
Jun 10, 2024
Comment on lines
+12
to
+19
| <a href="/" id="panda-market-logo"> | ||
| <picture> | ||
| <source srcset="images/logo/panda-market-logo-mobile-text.png" media="(max-width: 767px)"> | ||
| <source srcset="images/logo/panda-market-logo.png" media="(max-width: 1200px)"> | ||
| <img src="images/logo/panda-market-logo.png" alt="판다마켓 홈" width="153"> | ||
| </picture> | ||
| </a> | ||
|
|
There was a problem hiding this comment.
picture 태그로 반응형 이미지 제공하고 있군요! 굳굳!! 👍🏻
Comment on lines
+225
to
+226
| background-color: var(--gray900); | ||
| color: var(--gray400); |
There was a problem hiding this comment.
좋습니다!
컬러 변수로 바꾸니 같은 gray여도 어둡거나 밝거나 차이를 알기 쉬워졌어요!
There was a problem hiding this comment.
index.html이랑 셋트셋트로 쓰이는 것 같은 css네요
home.css -> index.css로 수정해보는건 어떨까요?
| top: 0; | ||
| } | ||
|
|
||
| #panda-market-logo { |
There was a problem hiding this comment.
id 선택자는 class도 써보고, tag도 써보고 다 써봤는데도 안되면 꺼내는 카드로 써보시는건 어떨까요?
대부분은 class로도 커버가 가능합니다. :-)
Comment on lines
+40
to
+52
| header { | ||
| width: 100%; | ||
| height: 70px; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| background-color: var(--white); | ||
| border-bottom: 1px solid #dfdfdf; | ||
| /* Sprint Mission 2 기본 요구사항: | ||
| 아래로 스크롤 해도 상단 네비게이션 바(Global Navigation Bar)가 최상단에 고정됩니다. */ | ||
| position: fixed; | ||
| top: 0; | ||
| } |
There was a problem hiding this comment.
미디어 쿼리에서 동일한 규칙이 반복되서 사용되고, 크기나 다른 수치가 달라지고 있는건 없어서
미디어 쿼리에 포함되지않아도 무방한 공통 코드 인 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
PC: 1200px 이상
Tablet: 768px 이상 ~ 1199px 이하
Mobile: 375px 이상 ~ 767px 이하
375px 미만 사이즈의 디자인은 고려하지 않습니다
심화
주요 변경사항
멘토에게