Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change img file name 2. Add class on h3 and p tag 3. Add color variable (global.css)
…int-Mission into Basic-이형준-sprint3
로고이미지 좌우로 클릭할 수 있는 너비가 생겨서 수정함
jyh0521
approved these changes
Jun 8, 2024
Comment on lines
+7
to
+17
| <meta property="og:title" content="판다마켓"/> | ||
| <meta property="og:type" content="website"/> | ||
| <meta property="og:url" content="https://leehj322-codeit.netlify.app/"/> | ||
| <meta property="og:discription" content="일상의 모든 물건을 거래해보세요"/> | ||
| <meta property="og:image" content="https://leehj322-codeit.netlify.app/images/preview_img.png"/> | ||
|
|
||
| <meta name="twitter:title" content="판다마켓"/> | ||
| <meta name="twitter:card" content="summary"/> | ||
| <meta name="twitter:url" content="https://leehj322-codeit.netlify.app/"/> | ||
| <meta name="twitter:description" content="일상의 모든 물건을 거래해보세요"/> | ||
| <meta name="twitter:image" content="https://leehj322-codeit.netlify.app/images/preview_img.png"/> |
| @@ -37,7 +51,7 @@ | |||
| <div class="main-page1"> | |||
| <div class="main-page left-main"> | |||
| <div> | |||
| <img class="main-page-img" src="/images/img_home_01.png" alt="홈 이미지 1" /> | |||
| <img class="main-page-img" src="/images/img_home_items.png" alt="홈 이미지 1" /> | |||
There was a problem hiding this comment.
이미지 이름들 더 명시적으로 수정해주신 점 좋네요!
| @@ -17,7 +17,7 @@ | |||
| <body> | |||
| <header> | |||
| <div class="logo-block"> | |||
| <a href="../index.html"> | |||
| <a href="/"> | |||
| .simple-login { | ||
| background-color: #e6f2ff; | ||
| background-color: var(--simple-login-color); |
header의 로고 이미지를 모바일로 넘어가면서 typo만 있는 이미지로 교체하게 되는데 html상에서 img 태그를 2개 놓고 교체하는게 좋을까요 css에서 url로 교체하는게 좋을까요? (현재는 html에서 img태그 2개 사용했습니다.)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본 요구사항
체크리스트 (기본)
공통
랜딩 페이지
로그인, 회원가입 페이지 공통
체크리스트 (심화)
피드백 반영
주요 변경사항
사이트 배포 링크
스크린샷
멘토에게