Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaeSang1998
reviewed
Jun 12, 2024
| <button class="headline-button">구경하러 가기</button> | ||
| </a> | ||
| </div> | ||
| </section><!--headline END--> |
There was a problem hiding this comment.
어떤 값이 끝나는 지점에 주석은 굳이 불필요합니다!
JaeSang1998
reviewed
Jun 12, 2024
There was a problem hiding this comment.
이미지 파일을 보기좋게 잘 분리해주셨네요! 이렇게 파일을 보기쉽게 잘 정리하는건 매우매우 좋은 습관입니다!
| <a href="/" > | ||
| <img class="logo-icon" src="./images/logo/logo.png" alt="판다마켓 로고"> | ||
| </a> | ||
| <a href="./login.html"> |
There was a problem hiding this comment.
태그 안에 태그를 중첩해서 사용하지 않고, 버튼에 클릭 이벤트를 추가하는 방법도 있습니다! 혹은 button 에 as 등을 쓰는 방법도 있어요 :)
| color: #E5E7EB; | ||
| } | ||
|
|
||
| @media(min-width: 1200px) and (max-width: 1920px){/* 데스크톱 뷰포트 설정*/ |
There was a problem hiding this comment.
반응형 디자인을 고려해주셨군요 :) 미디어 쿼리는 이해하고 있으면 나중에 큰 도움이 될거에요!!
There was a problem hiding this comment.
css 는 한 파일로 되어있는데, 공용과 각각 페이지에 필요한 css 를 따로 분리해서 관리하면 나중에 유지보수, 확장성에 더욱 용이합니다!
| </div> | ||
| </section><!--headline END--> | ||
|
|
||
| <section class="content"> |
There was a problem hiding this comment.
각각의 html 구획을 semantic 하게 잘 나눠주셨네요! 의미 있는 태그로 분리하는건 아주 좋은 습관입니다.
There was a problem hiding this comment.
감사합니다! 수정해서 보완해보겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게
-늦게 제출해서 죄송합니다.