Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Aug 26, 2024
| @@ -37,7 +38,7 @@ function AddComment({ id, setCommentList }: AddCommentProps) { | |||
| let newComment: IComment; | |||
| try { | |||
| const response = await axios.post( | |||
| `/articles/${id}/comments`, | |||
| API_PATH.articleComments(id), | |||
| @@ -0,0 +1,30 @@ | |||
| import Image, { StaticImageData } from "next/image"; | |||
|
|
|||
| interface Data { | |||
There was a problem hiding this comment.
Data보다 좀 더 구체적인 네이밍이면 좋겠습니다 ! ^^
Comment on lines
+16
to
+22
| if (typeof window !== "undefined") { | ||
| const isSignedIn = !!localStorage.getItem("user_information"); | ||
| useEffect(() => { | ||
| setIsLogin(isSignedIn); | ||
| }, [isSignedIn]); | ||
| } | ||
|
|
There was a problem hiding this comment.
이 코드가 잘 동작하나요... ? useEffect는 조건문안에서 사용 할 수 없는 걸로 기억이 납니다.
에러가 안났어요?
There was a problem hiding this comment.
오잉 그렇네요...??? 에러는 없었는데 이상하네요
일단 수정해두었습니다!
Comment on lines
+16
to
+19
| import dayjs from "dayjs"; | ||
| import "dayjs/locale/ko"; | ||
|
|
||
| dayjs.locale("ko"); |
Comment on lines
+144
to
+146
| Home.getLayout = function getLayout(page: ReactElement) { | ||
| return <>{page}</>; | ||
| }; |
There was a problem hiding this comment.
Layout 이렇게 하신거 잘 하신 것 같아요. 조건부 렌더링도 있지만 Next에서 권장하는 방법대로 잘 하셨네용 !
Comment on lines
+113
to
+118
| {errors.email && errors.email.type === "required" && ( | ||
| <p>이메일을 입력해주세요</p> | ||
| )} | ||
| {errors.email && errors.email.type === "pattern" && ( | ||
| <p>잘못된 이메일 형식입니다</p> | ||
| )} |
There was a problem hiding this comment.
꼼곰한 에러 처리 잘 하셨네용. 따로 컴포넌트로 만드는 것도 좋을 것 같아요.
const EmailErros = () => {
return <>
{errors.email && errors.email.type === "required" && (
<p>이메일을 입력해주세요</p>
)}
{errors.email && errors.email.type === "pattern" && (
<p>잘못된 이메일 형식입니다</p>
)}
</>
}
Comment on lines
+151
to
+156
| {errors.password && errors.password.type === "required" && ( | ||
| <p>비밀번호를 입력해주세요</p> | ||
| )} | ||
| {errors.password && errors.password.type === "minLength" && ( | ||
| <p>비밀번호를 8자 이상 입력해주세요</p> | ||
| )} |
There was a problem hiding this comment.
여기두 에러 보여주기용 컴포넌트를 따로 만들어서 렌더링하면 좀 더 깔끔 할 것 같아요 !
Comment on lines
+79
to
+83
| const isSignedUp = !!localStorage.getItem("user_information"); | ||
| if (isSignedUp) { | ||
| // TODO: toast 메시지 - 회원가입 내역 존재 | ||
| router.push(`/login`); | ||
| } |
There was a problem hiding this comment.
이 부분은 useEffect로 컨트롤해야 잘 동작 할 것 같아요.
Comment on lines
+60
to
+62
| const isFormCompleted = email && nickname && password && passwordConfirmation; | ||
| const isPasswordValid = password === passwordConfirmation; | ||
| const isButtonDisabled = !isFormCompleted || !isPasswordValid || isSubmitting; |
There was a problem hiding this comment.
ts-patterns를 사용하면 좀 깔금하게 해결 될 것 같은 부분처럼 보여요 ㅎㅎㅎ
|
피드백도 잘 적용해주시고 완성까지 해주셨네요 ! 수고하셨습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
회원가입
로그인
메인
심화
추가할 것
주요 변경사항
스크린샷
멘토에게