Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Aug 26, 2024
| @@ -0,0 +1,46 @@ | |||
| import axios from "axios"; | |||
|
|
|||
| interface valuetype { | |||
There was a problem hiding this comment.
valueType 보다 어떤 value인지 좀 더 명확하게 해주시면 좋을 것 같아요 !
|
|
||
| export const postAuthSignIn = async (body: valuetype) => { | ||
| try { | ||
| const res = await axios.post(`${apiUrl}/auth/signIn`, body, { |
There was a problem hiding this comment.
이런 부분은 axios instance로 미리 설정 할 수 있겠죠 !
There was a problem hiding this comment.
https://nextjs.org/docs/pages/building-your-application/routing/pages-and-layouts
nextjs layout을 이용해서 조건부 렌더링보다는 nextjs 스러운 방식으로 Header를 구성해보시는게 어떨 까요?
Comment on lines
+3
to
+6
| const instance = axios.create({ | ||
| baseURL: process.env.NEXT_PUBLIC_API_BASE_URL, | ||
| withCredentials: true, | ||
| }); |
| const [value, setValue] = useState<valuetype>(INITIAL_VALUES); | ||
| const navigate = useNavigate(); | ||
|
|
||
| const mutation = useMutation({ |
There was a problem hiding this comment.
이것도 네이밍을 mutation보다는 어떤 일을 하는지 좀 더 명확하게 네이밍을 하시면 좋을 것 같아요 !
| </button> | ||
| </form> | ||
| <div className={style.easylogin}> | ||
| 간편 로그인하기 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
회원가입
로그인
메인
멘토에게