Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisarnjs
reviewed
Aug 20, 2024
| <> | ||
| <section className={styles.contentWrapper}> | ||
| <p className={styles.content}>{comment.content}</p> | ||
| <Image src="/ic_modify.png" alt="수정 아이콘" width={24} height={24} /> |
| @@ -12,7 +12,7 @@ const Dropdown = ({ options, selectedValue, onSelect }: DropdownProps) => { | |||
| const [isOpen, setIsOpen] = useState(false); | |||
|
|
|||
| const toggleDropdown = () => { | |||
| setIsOpen(!isOpen); | |||
| setIsOpen((prev) => !prev); | |||
|
|
||
| const nextPreviewImg = URL.createObjectURL(value); | ||
| setPreviewImg(nextPreviewImg); | ||
| setShowPreview(true); |
There was a problem hiding this comment.
shopPreview 상태는 previewImg 상태로부터 유도될 수 있을 것 같아서 굳이 필요 없는 state 같다 라는 생각이 드는데 한번 고민해보시면 좋을 것 같네요!
| }; | ||
|
|
||
| useEffect(() => { | ||
| if (!value) return; |
| setPreviewImg(nextPreviewImg); | ||
| setShowPreview(true); | ||
|
|
||
| return () => { |
| /> | ||
| </div> | ||
| <div> | ||
| {showPreview ? ( |
There was a problem hiding this comment.
조건 결과 하나가 null일 경우에는 &&연산자를 사용해주시는 것이 가독성 면에서도 좋습니다!
| ]; | ||
|
|
||
| async function getArticles(orderBy: string, keyword: string) { | ||
| const nextArticles: Article[] = await fetchAllArticles(orderBy, keyword); |
There was a problem hiding this comment.
try catch 로 api 호출하는 함수를 감싸주면 더 안전하고 좋을 것 같아요!
| export default instance; | ||
|
|
||
| export const fetchArticles = async () => { | ||
| try { |
There was a problem hiding this comment.
오! 여기는 에러 핸들링을 아주 잘해주셨어요!
| let article = null; | ||
| try { | ||
| const res = await instance.get(`/articles/${id}`); | ||
| article = res.data; |
There was a problem hiding this comment.
여기서 성공했다면 필요한 props들 바로 return 해줘도 좋을듯!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품 등록 페이지
상품 상세 페이지
주요 변경사항
스크린샷
멘토에게