Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
lisarnjs
reviewed
Jun 23, 2024
.eslintrc.cjs
Outdated
There was a problem hiding this comment.
오 대박 벌써 eslint !? 아주 좋은 시작입니다 👍
| function App() { | ||
| return ( | ||
| <> | ||
| <BrowserRouter> |
There was a problem hiding this comment.
다음 미션이 어떨지 모르겠지만 중첩 라우팅도 한번 사용하시면 금방 실력이 늘거에요 👍
| import AuthSignUp from "./AuthSignUp"; | ||
| import AuthFooter from "./AuthFooter"; | ||
|
|
||
| function AuthContainer({ isLogin, onClickAuthHandle }) { |
There was a problem hiding this comment.
오 세환님 코드 스타일이 벌써 퀄리티가 너무 좋은데요 나중에는 이걸 Context로 만들어서 isLogin여부를 props로 받지 않고 변수로 불러와서 사용해볼 수 있도록 수정해보면 더 gooood일거 같습니다
| </div> | ||
| <ul className="footer-right"> | ||
| <li> | ||
| <a href="http://twitter.com" target="_blank"></a> |
There was a problem hiding this comment.
요기 target="_blank"랑 세트로 같이 다니는 친구가 있는데 뭔지 아시나요!?
아래 아티클 첨부해두었으니 읽어보시면 아마 들어보셨을 거 같아요 :)
| <BestUl> | ||
| {items.map((item) => { | ||
| return ( | ||
| <li key={item.id}> |
There was a problem hiding this comment.
리액트의 key값은 항상 이렇게 고유한 값을 가져야함을 잊지 마세요! 👍
| const [orderBy, setOrderBy] = useState("recent"); | ||
| const loadItems = async ({ pageSize, orderBy, bestLoad = false }) => { | ||
| const { list } = await getItems({ pageSize, orderBy }); | ||
| if (bestLoad) { |
| const [openSort, setOpenSort] = useState(false); | ||
|
|
||
| const sortHandle = () => { | ||
| setOpenSort(!openSort); |
There was a problem hiding this comment.
setState로 이전값을 반전시키는데 내가 예상한 대로 코드가 동작하기 위해서는
setOpenSort(prev => !prev) 로 이전값을 가져와서 이전값을 반전시킨다 로 코드를 작성해주시는 것을 추천할게요!
kimsayhi
force-pushed
the
React-김세환-sprint5
branch
from
fa6116b to
4dc5dd0
Compare
kimsayhi
force-pushed
the
React-김세환-sprint5
branch
2 times, most recently
from
be3337d to
b831712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본 요구사항
심화요구사항
멘토님꼐