-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[장혁수] sprint5 #144
The head ref may contain hidden characters: "React-\uC7A5\uD601\uC218-sprint5"
[장혁수] sprint5 #144
Conversation
…ithub-actions [Fix] delete merged branch github action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
과제하느라 고생하셨습니다! 계속 발전시켜주시면 좋을 것 같아요 ㅎㅎ
@@ -0,0 +1,10 @@ | |||
<!DOCTYPE html> | |||
<html lang="en"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang ko로 바꿔주시면 좋을 것 같아요!
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<title>React App</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 판다마켓이니까 title도 변경해주시면 될 것 같습니다.
src/App.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저번에 말씀드린대로 App.js에다가 헤더 잘 넣어주셨네요! Items는 라우터 훅을 사용해서 원하는 경로일때만 띄우게 해주시면 좋을 것 같습니다.
src/index.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
초기화 목적인 css라면, index.html에 link 태그 혹은 App.js에서 import로 불러오게 해주시면 됩니다!
요구사항
기본
중고마켓
중고마켓 반응형
Desktop : 4개 보이기
Tablet : 2개 보이기
Mobile : 1개 보이기
Desktop : 12개 보이기
Tablet : 6개 보이기
Mobile : 4개 보이기
심화
주요 변경사항
스크린샷
멘토에게