Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- accessToken을 로컬스토리지에 저장 - refreshToken을 통해 accessToken 재발급 요청
- AuthContext - 로그인, 로그아웃 함수 - useAuth 커스텀 훅
lisarnjs
reviewed
Jun 17, 2024
| display: inline; | ||
| cursor: default; | ||
| span { | ||
| @include font-style(16px, 800, $grey-800); |
There was a problem hiding this comment.
오 mixin 으로 font-style을 만들어주셨군요!! 👍
| [className]: className, | ||
| }); | ||
|
|
||
| return <div className={pageClassName} {...props} />; |
There was a problem hiding this comment.
classNames로 불러오기 너무 길어서 저는 이런식으로 사용합니다!
import classnames from 'classnames/bind'
const cx = classnames.bind(styles)
<div className={cx(stylescontianer, {['authPage']: isAuthPage })}></div>| }, [router]); | ||
|
|
||
| const onSubmit: SubmitHandler<SignInFormValues> = async (data) => { | ||
| try { |
There was a problem hiding this comment.
try catch 너무 좋아요!
앞으로도 async await 쓸떄는 try catch를 기본적으로 사용해주는 습관!
| </span> | ||
| )} | ||
| </div> | ||
| <Button |
There was a problem hiding this comment.
보통은 CustomButton 처럼 일반 태그명과는 다른 좀더 컴포넌트의 목적이 드러나도록 컴포넌트명을 지어주는 것이 좋습니다!
| }); | ||
|
|
||
| // 토큰이 있으면 홈으로 리디렉션 | ||
| useEffect(() => { |
There was a problem hiding this comment.
useCheckLogin() 만 호출해도
const token = localStorage.getItem("accessToken");
if (token) {
toast.success("이미 로그인된 상태입니다.");
router.push("/");
}이 코드를 실행할 수 있도록 커스텀 훅으로 만들어줘서 여기저기 페이지에서 사용하면 로직 분리도 되고 너무 좋을 것 같은데요!/
| }; | ||
|
|
||
| return ( | ||
| <AuthContext.Provider value={{ user, signIn, signOut }}> |
There was a problem hiding this comment.
필요한 상태값이나 함수들을 context 로 관리해서 여기저기 사용되는 로직(함수)들을 재사용할 수 있어서 너무 좋은 것 같네요 👍
| if (error.response?.status === 401 && !isRefreshing) { | ||
| isRefreshing = true; | ||
|
|
||
| if (!refreshPromise) { |
There was a problem hiding this comment.
여기도 if문이 2개나 사용되면서 중첩됬는데 이를 수정해볼 수는 없을까요!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배포 링크
요구사항
Github에 PR(Pull Request)을 만들어서 미션을 제출합니다.
피그마 디자인에 맞게 페이지를 만들어 주세요.
기존의 스프린트 미션 8에 이어서 React, Typescript를 사용합니다.
기본
회원가입
로그인
메인
심화
주요 변경사항
스크린샷
멘토에게