[김보미] sprint11 #670
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ yarn-error.log* | |
|
|
||
| # local env files | ||
| .env*.local | ||
| .env | ||
|
|
||
| # vercel | ||
| .vercel | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,17 +104,17 @@ export default function BestPosts({ initialBestPosts }: BestPostsProps) { | |
| bestPosts.map((post) => ( | ||
| <Link | ||
| href={`/boards/${post.id}`} | ||
| className="h-[169px] w-[400px] rounded-[1rem] bg-gray-50 px-8 md:w-[380px] xl:w-full" | ||
| key={post.id} | ||
| > | ||
| <div className="bg-main inline-flex h-[30px] w-[102px] items-center justify-center rounded-b-[5rem]"> | ||
| <Image src={icon_medal} alt="" width={16} height={16} /> | ||
| <p className="text-[16px] text-white">Best</p> | ||
| </div> | ||
| <div className="flex h-[80px] items-center justify-between gap-[0.3rem]"> | ||
| <h3 className="m-0 p-0 font-bold">{post.title}</h3> | ||
| {post.image && ( | ||
| <div className="flex h-[72px] min-w-[72px] items-center justify-center rounded-[0.3rem] border-[1.5px] border-gray-100 bg-white"> | ||
| <Image | ||
| src={post.image} | ||
| alt="포스트 이미지" | ||
|
|
@@ -126,15 +126,13 @@ export default function BestPosts({ initialBestPosts }: BestPostsProps) { | |
| </div> | ||
| <div className="mt-4 flex items-end justify-between"> | ||
| <div className="flex items-center justify-start gap-[0.2rem]"> | ||
| <p className="text-[14px] text-gray-600"> | ||
| {post.writer.nickname} | ||
| </p> | ||
| <Image src={icon_favorite} alt="하트" width={16} height={16} /> | ||
| <p className="text-[14px] text-gray-600">{post.likeCount}</p> | ||
| </div> | ||
| <p className="text-[14px] text-gray-400"> | ||
| {formatDate(post.createdAt)} | ||
| </p> | ||
| </div> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ function FileInput({ name, value, initialPreview, onChange }: FileInputProps) { | |
| }, [value, initialPreview]); | ||
|
|
||
| return ( | ||
| <div className="bg-coolgray-100 relative my-2 h-[162px] w-[162px] overflow-hidden rounded-md lg:h-[282px] lg:w-[282px]"> | ||
| <div className="flex h-full w-full items-center justify-center"> | ||
| {preview ? ( | ||
| <Image | ||
|
|
@@ -80,7 +80,7 @@ function FileInput({ name, value, initialPreview, onChange }: FileInputProps) { | |
| /> | ||
| {value && ( | ||
| <button | ||
| className="hover:bg-main absolute right-2.5 top-2.5 h-6 w-6 cursor-pointer rounded-full border-none bg-black bg-opacity-40 p-1" | ||
| onClick={handleClearClick} | ||
| > | ||
| <Image src={icon_reset} alt="선택해제" width={26} height={26} /> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,13 +8,13 @@ import Image from "next/image"; | |
|
|
||
| function Footer() { | ||
| return ( | ||
| <footer className="b-[0] bg-footer relative mt-auto h-[160px] w-full py-6 text-white"> | ||
| <div className="container mx-auto flex flex-col-reverse items-center justify-between md:flex-row"> | ||
| <p className="relative -left-[10rem] top-[1rem] mb-4 text-sm md:left-0 md:top-0 md:mb-0 md:text-base"> | ||
| ©codeit - 2024 | ||
| </p> | ||
| <div className="flex flex-row items-center md:justify-between md:gap-[20rem]"> | ||
| <div className="text-footercodeit relative -left-[5rem] top-2 mb-4 flex items-center space-x-4 md:-left-0 md:top-0 md:mb-0"> | ||
| <p className="text-sm md:text-base"> | ||
| <Link href="./privacy.html">Privacy Policy</Link> | ||
| </p> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,21 +21,25 @@ export default function Header() { | |
|
|
||
| useEffect(() => { | ||
| const token = localStorage.getItem("accessToken"); | ||
| if (token) { | ||
| setAccessToken(token); | ||
| } | ||
| }, [router.pathname]); | ||
|
Comment on lines
22
to
+27
There was a problem hiding this comment. 전에 로그인 후 바로 적용이 안 되는 이슈가 있어서 reload()를 썼었는데 의존성 배열에 router.pathname을 넣으면 바로 반영되도록 수정했습니다. There was a problem hiding this comment. 이렇게 되면 리다이렉트 시 변경을 감지하고 리렌더링 시켜주는 걸까요?일단 논리적으로는 맞는 말이지만 근본적이진 못할 수 있을 것 같아요. |
||
|
|
||
| const handleProfileClick = () => { | ||
| setIsLogoutBoxVisible(!isLogoutBoxVisible); | ||
| }; | ||
|
|
||
| const logout = () => { | ||
| localStorage.removeItem("accessToken"); | ||
| localStorage.removeItem("refreshToken"); | ||
| setAccessToken(null); | ||
| setIsLogoutBoxVisible(false); | ||
| router.push("/"); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="fixed top-0 z-50 flex h-16 w-full items-center justify-between gap-4 bg-white px-6 py-0 lg:gap-12 lg:px-12 lg:py-4"> | ||
| <div className="flex items-center gap-4"> | ||
| <div | ||
| onClick={goToMain} | ||
|
|
@@ -55,18 +59,18 @@ export default function Header() { | |
| <nav className="flex flex-row gap-2 text-lg font-bold md:gap-8"> | ||
| <Link | ||
| href="/boards" | ||
| className={`hover:text-main ${ | ||
| pathName.includes("/boards") || pathName.includes("/addBoards") | ||
| ? "text-blue-500" | ||
| : "" | ||
| }`} | ||
| > | ||
| 자유게시판 | ||
| </Link> | ||
| <Link | ||
| href="/items" | ||
| className={`hover:text-main ${ | ||
| pathName === "/items" ? "text-main" : "" | ||
| }`} | ||
| > | ||
| 중고마켓 | ||
|
|
@@ -85,11 +89,8 @@ export default function Header() { | |
| /> | ||
| )} | ||
| {isLogoutBoxVisible && ( | ||
| <div className="absolute right-5 top-14 z-50 rounded-lg bg-white px-4 py-2 shadow-md lg:right-12 lg:top-16"> | ||
| <button className="text-gray-700 hover:text-main" onClick={logout}> | ||
| 로그아웃 | ||
| </button> | ||
| </div> | ||
|
|
@@ -98,7 +99,7 @@ export default function Header() { | |
| <button | ||
| id="btn_small" | ||
| onClick={goToSignin} | ||
| className="inline-flex cursor-pointer items-center justify-center rounded-md border-none bg-main px-6 py-2 text-white hover:bg-btn-2" | ||
| > | ||
| 로그인 | ||
| </button> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import React, { useMemo } from "react"; | ||
|
|
||
| type PaginationProps = { | ||
| currentPage: number; | ||
|
|
@@ -19,13 +19,10 @@ export default function Pagination({ | |
| onPageChange(currentPage + 1); | ||
| }; | ||
|
|
||
| const pages = useMemo( | ||
| () => Array.from({ length: totalPages }, (_, i) => i + 1), | ||
| [totalPages], | ||
| ); | ||
|
|
||
|
Comment on lines
+22
to
+25
There was a problem hiding this comment. 멘토님께서 저번 미션 때 메모이제이션을 추천해주셔서 처음으로 사용해봤습니다. 사실, 메모이제이션에 대해 깊이 이해하지는 못했고, 리액트도 아직 익숙하지 않아서 메모이제이션이 다소 어렵게 느껴졌습니다. 언제 사용하는 것이 좋을지 판단하는 것도 쉽지 않네요..ㅎㅎ.. There was a problem hiding this comment. ㅎㅎㅎ 그쵸. 다음 아티클을 읽어보세요 !
|
||
| return ( | ||
| <div className="mt-8 flex items-center justify-center gap-4"> | ||
|
|
@@ -41,8 +38,8 @@ export default function Pagination({ | |
| <div | ||
| key={i} | ||
| className={`flex h-10 w-10 cursor-pointer items-center justify-center rounded-full border border-gray-300 font-bold ${ | ||
| currentPage === i ? "bg-btn-1 text-white" : "" | ||
| } hover:bg-btn-1 hover:text-white`} | ||
| onClick={() => onPageChange(i)} | ||
| > | ||
| {i} | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 ! 훨신 깔끔해졌네요 😊
위와 같이
?는 지워도 될 것으로 보여요 !