Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endmoseung
approved these changes
Jun 10, 2024
src/api/api.ts
Outdated
| export const getBestPosts = async (params: string): Promise<writing[]> => { | ||
| const URL = `/articles?${params}`; | ||
| try { | ||
| const response: AxiosResponse<any> = await instance.get(URL); | ||
| const response: AxiosResponse<articles> = await instance.get(URL); |
src/api/api.ts
Outdated
| @@ -30,7 +24,7 @@ export const getBestPosts = async (params: string): Promise<writing[]> => { | |||
| export const getTotalPosts = async (params: string): Promise<writing[]> => { | |||
| const URL = `/articles?${params}`; | |||
| try { | |||
| const response: AxiosResponse<any> = await instance.get(URL); | |||
| const response: AxiosResponse<articles> = await instance.get(URL); | |||
There was a problem hiding this comment.
Api Type은 암묵적으로 앞글자를 대문자로 넣고 뒤에 ~~Type을 넣어줘요 아니면 컴포넌트랑 헷갈릴 수 있어요.
Comment on lines
+43
to
+50
| if (!Cookies.get('accessToken')) { | ||
| const response = await instance.post(TEMP_URL, { | ||
| email: '[email protected]', | ||
| password: 'abcd1234', | ||
| }); | ||
| const { accessToken, refreshToken } = response.data; | ||
| Cookies.set('accessToken', accessToken); | ||
| Cookies.set('refreshToken', refreshToken); |
There was a problem hiding this comment.
accessToken이나 refreshToken같은 키값은 따로 상수로 관리하는것도 좋아요.
왜냐하면 해당 키값들을 상수로 관리하면 흩어져있는 값들에 대한 관리가 가능하고 휴먼에러의 오류가 줄어드렁요.
| Cookies.set('accessToken', accessToken); | ||
| Cookies.set('refreshToken', refreshToken); | ||
| } | ||
| } catch (error) {} |
There was a problem hiding this comment.
error는 throw해줘서 해당 에러를 catch하는 곳에서 처리를 해주셔도 좋겠네요:)
src/api/api.ts
Outdated
Comment on lines
55
to
62
| export const postImage = async () => { | ||
| const URL = '/images/upload'; | ||
|
|
||
| try { | ||
| const response = await instance.post(URL); | ||
| response.data(); | ||
| } catch (error) {} | ||
| }; |
There was a problem hiding this comment.
만약 repsonse로 받은 값을 쓰지 않는다면 이렇게 해줘도 되겠네요!
Suggested change
| export const postImage = async () => { | |
| const URL = '/images/upload'; | |
| try { | |
| const response = await instance.post(URL); | |
| response.data(); | |
| } catch (error) {} | |
| }; | |
| export const postImage = async () => { | |
| const URL = '/images/upload'; | |
| try { | |
| await instance.post(URL); | |
| } catch (error) {} | |
| }; |
Comment on lines
+14
to
+23
| if (e.target.name === 'title') { | ||
| setFormData((prev) => ({ ...prev, ['title']: e.target.value })); | ||
| } else if (e.target.name === 'content') { | ||
| setFormData((prev) => ({ ...prev, ['content']: e.target.value })); | ||
| } else if (e.target.name === 'image') { | ||
| const file = e.target.files?.[0]; | ||
| if (file) setFormData((prev) => ({ ...prev, ['image']: file })); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
여기서 e.target.name가 재사용되니 const targetName = e.target.name;으로 재사용해도 도겠네요
| e.preventDefault(); | ||
| }; | ||
| useEffect(() => { | ||
| tempSignUP(); |
There was a problem hiding this comment.
tempSignup은 비동기함수인데 사용하는곳에서 비동기 설정을 안해주시면 그냥 동기함수처럼 사용됩니다! 여기도 비동기 함수로 바꿔주세요:)
Comment on lines
+19
to
+21
| type='submit' | ||
| disabled={!(formData.title && formData.content)} | ||
| className={style.registerBtn} |
There was a problem hiding this comment.
좋아요! 여기서 Type을 button으로 바꿔주면 form으로 엔터쳣을때 동작 안할거에요!
| @@ -5,9 +5,13 @@ import SearchBar from './SearchBar'; | |||
| const SelectAndSearchContainer = () => { | |||
| const router = useRouter(); | |||
| const ref = useRef<HTMLInputElement>(null); | |||
| const [selectedOption, setSelectedOption] = useState('recent'); | |||
| const [selectedOption, setSelectedOption] = useState<'recent' | 'like'>( | |||
Comment on lines
+4
to
11
| const day = date.getDay(); | ||
| const month = attachZero(date); | ||
| return `${year}. ${month}. ${day} `; | ||
| }; | ||
|
|
||
| const attachZero = (date: Date) => { | ||
| let month: number | string = date.getMonth() + 1; | ||
| if (month < 10) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
상품 등록 페이지 주소는 “/addboard” 입니다.(o)
게시판 이미지는 최대 한개 업로드가 가능합니다.(o)
각 input의 placeholder 값을 정확히 입력해주세요.(o)
이미지를 제외하고 input 에 모든 값을 입력하면 ‘등록' 버튼이 활성화 됩니다.(o)
회원가입, 로그인 api를 사용하여 받은accessToken을 사용하여 게시물 등록을 합니다.(x)
‘등록’ 버튼을 누르면 게시물 상세 페이지로 이동합니다.(x)
상품 상세 페이지 주소는 “/addboard/{id}” 입니다.(x)
댓글 input 값을 입력하면 ‘등록' 버튼이 활성화 됩니다.(x)
활성화된 ‘등록' 버튼을 누르면 댓글이 등록됩니다.(x)
주요 변경사항
스크린샷
멘토에게