Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devym-37
approved these changes
May 21, 2024
| export const SignupLayout = () => { | ||
| return ( | ||
| <ContainerStyled> | ||
| <ItemsStyled></ItemsStyled> |
There was a problem hiding this comment.
해당 부분들은
이렇게 수정해주시면 좋을 것 같습니다
| mobile: "(max-width: 768px)", | ||
| }; | ||
|
|
||
| export default device; |
There was a problem hiding this comment.
공통으로 사용되는 부분을 config로 분리해주신 것 좋습니다
| export const passwordErrCheck = document.querySelector(".password-err-check"); | ||
|
|
||
| /*회원가입 시 비밀번호 값이 8자 미만이로 있거나 문자열만 있는 경우 - 정규 표현식*/ | ||
| export const regex = /^(?=.*[a-zA-Z])(?=.*\d)[a-zA-Z\d]{8,}$/; |
There was a problem hiding this comment.
현재 regex부분도 공통 추후에 더 많아지면, 따로 파일로 분리하여 관리하시면 좋을 것 같습니다
| "비밀번호가 일치하지 않아요." | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
password 관련한 함수를 해당 파일로 분리하신 것도 잘 작성해주셨습니다
| <IconStyled> | ||
| <IconBoxStyled> | ||
| <a href="https://www.google.com/" target="_blank"> | ||
| <Image src={signGoogleback} /> |
There was a problem hiding this comment.
이미지 태그의 경우 alt속성값을 작성해주시면 좋을 것 같습니다
| font-weight: 600; | ||
| `; | ||
|
|
||
| export default SigninHeader; |
| margin-top: 0.6rem; | ||
| `; | ||
|
|
||
| export default SigninHeader; |
There was a problem hiding this comment.
스타일드 컴포넌트명에 styled를 붙여주신 것이 좋은 것 같습니다. 어떤 컴포넌트가 스타일드 컴포넌트인지 잘 구별되어 좋은 것 같습니다.
| form.addEventListener("submit", mainSignInFunction); | ||
| eyeBtn.forEach((btn) => { | ||
| btn.addEventListener("click", eyeBtnFunction); | ||
| }); |
There was a problem hiding this comment.
유틸함수와 fetch함수가 같이 있어서 분리해주시면 좋을 것 같습니다
| return false; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
해당 파일도 유틸함수와 api fetch 함수가 같이 있어서 분리해주시면 좋을 것 같습니다
| if (accessToken) { | ||
| location.href = "../folder.html"; | ||
| } | ||
| }; |
There was a problem hiding this comment.
공통 유틸 함수로 잘 작성해주신 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본
심화
주요 변경사항
스크린샷
멘토에게