Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
reviewed
May 20, 2024
Comment on lines
+9
to
+13
| if (response.status === 200) { | ||
| return true; //로그인 성공 | ||
| } else { | ||
| return false; //로그인 실패 | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (response.status === 200) { | |
| return true; //로그인 성공 | |
| } else { | |
| return false; //로그인 실패 | |
| } | |
| return response.status === 200 |
| <div className={styles.buttonwrapper}> | ||
| <div className={styles.actionbutton}> | ||
| <Image | ||
| className={styles.actionbutton_image} |
| import styles from "./AllButton.module.css"; | ||
|
|
||
| const AllButton = ({ active, onClick }) => { | ||
| interface AllButtonProps { | ||
| active: boolean; |
There was a problem hiding this comment.
boolean 값은 is~, has~ 로 시작하는 게 일반적이라 isActive 추천드려요!
Comment on lines
+11
to
+15
| <button | ||
| className={`${styles.StyledButton} ${buttonClass}`} | ||
| onClick={onClick} | ||
| color-type={btnType} | ||
| > |
There was a problem hiding this comment.
ButtonHTMLAttributes 을 쓰신만큼 바로 활용해주셔도 좋을 거 같아요!
Suggested change
| <button | |
| className={`${styles.StyledButton} ${buttonClass}`} | |
| onClick={onClick} | |
| color-type={btnType} | |
| > | |
| const Button = ({ children, btnType, onClick, ...rest }: ButtonProps) => { | |
| ... | |
| <button | |
| className={`${styles.StyledButton} ${buttonClass}`} | |
| onClick={onClick} | |
| color-type={btnType} | |
| ...rest | |
| > |
Comment on lines
+35
to
+38
| {Array.isArray(link) ? ( | ||
| link.map((item, index) => ( | ||
| <Card key={index} link={item} isFolderPage={isFolderPage} /> | ||
| )) |
There was a problem hiding this comment.
러프하게 생각해봤을 때 2차원 배열이면 위의 사진과 같이 1차원 배열로 만들어서 넣어주는 방법이 있구용,,! 아니면 이 컴포넌트를 부르는 곳에서 직접 map 을 해서 넣어주시는 것도 좋을 거 같아요!
| const { data: folderData, isLoading } = useFolderList(); | ||
|
|
||
| if (isLoading) return <div>Loading...</div>; | ||
| if (!folderData) return null; | ||
|
|
||
| const folderId = null; | ||
| const folderId = ""; |
There was a problem hiding this comment.
const 값을 굳이 정해줄 필요 없을 거 같아요!
Comment on lines
+35
to
+39
| if (modalState[modalType]) { | ||
| closeModal(modalType); | ||
| } else { | ||
| openModal(modalType); | ||
| } |
There was a problem hiding this comment.
early return 적용해주시면 좋을 거 같아요~
| if (!Array.isArray(folders) || folders.length === 0) { | ||
| interface FolderMenuListProps { | ||
| folders: Folder; | ||
| activeButton: number | string | null; |
There was a problem hiding this comment.
activeButtonId 일 거 같아요...? (진짜 DOM 이 아니라면용)
| return ( | ||
| <div className={styles.footericons}> | ||
| {SOCIAL_SHARES.map((share, index) => ( | ||
| <Link key={index} href={share.url} target="_blank"> |
There was a problem hiding this comment.
key 를 index 로 주는 건 안주는 것과 동일해요! share.url 은 아마도 고유한 값일 거 같은데 이 경우 고유한 값을 넣어주면 좋을 거 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
멘토에게