Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
approved these changes
May 7, 2024
| @@ -3,7 +3,7 @@ interface IButtonModule { | |||
| children: React.ReactNode; | |||
| $btnClass: string; | |||
| $BeforButtonIcon?: string; | |||
| $id?: string; | |||
| $id?: string | number; | |||
There was a problem hiding this comment.
string | number 이면 사실상 아주 광범위한 범위라서 아예 string 또는 number 로 박아두고,
button컴포넌트를 사용하는 곳들에서 타입을 맞춰서 넣어주는 걸 추천드려요!
| )} | ||
| </> | ||
| <> | ||
| <div style={{position:'relative'}}> |
There was a problem hiding this comment.
특별한 경우가 아니라면 인라인 스타일은 지양해주세요!
| const { value: contant, isLoading: contantLoading } = | ||
| useFatchDataLoad<IFolderContentApi>(dynamicAPI); | ||
| const [search, setSearch] = useState<any>(); | ||
| const [searchContatn, setSearchContant] = useState<any>(); |
There was a problem hiding this comment.
any 는 왠만하면 지양해주세요!
Suggested change
| const [searchContatn, setSearchContant] = useState<any>(); | |
| const [searchContant, setSearchContant] = useState<string>(); |
| <div> | ||
| </FolderContainHead> | ||
|
|
||
| {loading ? |
There was a problem hiding this comment.
의미상으로 loading 이면 이 와야하는데 반대로 적혀있네요!
| useFatchDataLoad<IFolderContentApi>(`${FOLDER_CONTANT_LIST_API}?folderId=${id}`); | ||
|
|
||
| const filter = menus?.data.some(data => `${data.id}` === id) | ||
| if(filter === false) { |
There was a problem hiding this comment.
Suggested change
| if(filter === false) { | |
| if(!filter) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항