Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
reviewed
Apr 28, 2024
| setTargetName(event.target.value); | ||
| } | ||
| function handleCloseModal(isOpen) { | ||
| setIsModalOpen(isOpen); // 모달을 닫습니다. |
There was a problem hiding this comment.
모달을 닫는 동작의 경우 굳이 isOpen 인자를 안넘겨주고 false를 넣어주면 될 거 같아요~
Comment on lines
+68
to
+88
| {link.image_source ? ( | ||
| <img | ||
| src={moreoptionicon} | ||
| alt="링크 게시물 옵션 버튼 아이콘 " | ||
| src={link.image_source} | ||
| className={`${styles.card_img} ${ | ||
| isHovering ? styles.zoomIn : '' | ||
| }`} | ||
| onMouseOver={handleMouseOver} | ||
| onMouseOut={handleMouseOut} | ||
| alt={link.title} | ||
| /> | ||
| </button> | ||
| ) : ( | ||
| <img | ||
| src={thumbnail} | ||
| className={`${styles.card_img} ${ | ||
| isHovering ? styles.zoomIn : '' | ||
| }`} | ||
| onMouseOver={handleMouseOver} | ||
| onMouseOut={handleMouseOut} | ||
| alt="thumbnail_img" | ||
| /> | ||
| )} |
There was a problem hiding this comment.
이미지의 source, alt 내용만 다른 거 같은데 src에 image_source ?? thumbnail 로 하면 굳이 분기 처리 안해도 될 거 같아요
| )) | ||
| ) : ( | ||
| <div className={styles.noLinkText}> | ||
| <p>저장된 링크가 없습니다</p> | ||
| </div> | ||
| )} | ||
| {isModalOpen && ( |
There was a problem hiding this comment.
여기서 open이 되어있는지 확인하고 내부에서도 또 모달이 open 상태인지 확인하고 있어서, 한 군데서만 확인해주면 좋을 거 같습니다!
Comment on lines
+16
to
+17
| <div className={styles.modal}> | ||
| <div className={styles.modal__content}> |
There was a problem hiding this comment.
어느 정도 모달마다 뒤에는 dimmed 되고, 모달 닫는 창이 있고 등의 공통점이 있어요!
해당 부분을 공통 모달로 해서 Modal 컴포넌트를 만들고, 각기 다른 모달들은 Modal 컴포넌트에 children 으로 내용을 넘기는 구조를 추천드립니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게