Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arthurkimdev
approved these changes
May 3, 2024
Comment on lines
+18
to
+38
| "api/*": [ | ||
| "src/api/*" | ||
| ], | ||
| "assets/*": [ | ||
| "src/assets/*" | ||
| ], | ||
| "components/*": [ | ||
| "src/components/*" | ||
| ], | ||
| "constants/*": [ | ||
| "src/constants/*" | ||
| ], | ||
| "pages/*": [ | ||
| "src/pages/*" | ||
| ], | ||
| "types/*":[ | ||
| "src/types/*" | ||
| ], | ||
| "util/*": [ | ||
| "src/util/*" | ||
| ], |
There was a problem hiding this comment.
"@util/* 이거처럼 @ 없이 이렇게 설정을 하기도 합니다! 설정 굳!
| @@ -53,7 +53,7 @@ function SharePage() { | |||
| <Banner userName={users?.name} /> | |||
| <div className="sharePage_contents"> | |||
| <SearchBar /> | |||
| <CardsArea foldersData={folders} /> | |||
| <CardsArea folderList={folders} /> | |||
There was a problem hiding this comment.
명시적으로 array 관련된 값들은 ***List / ***Item 이렇게 구분해서 네이밍을 해요. 기존 Data -> List 로 변경해주셔서 더 좋네요.
혹은 복수 / 단수로 구분도 한답니다.
Comment on lines
+3
to
+8
| import { ButtonGroupProps } from "../types/type"; | ||
|
|
||
| function ButtonGroup({ buttonList }: ButtonGroupProps) { | ||
| if (!Array.isArray(buttonList)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
이렇게 early return 을 추가하는 부분 좋습니다. 이 곳 말고도 프로젝트 내 다양한 곳에 early return 추가할 부분이 있을거에요. early return 을 습관화해서 비효율적인 랜더링을 막으면 최적화에 도움이 됩니다.
Comment on lines
+21
to
+22
| export async function getUserFolders(userId: string = '1', folderId?: string ) { | ||
| let url = "/users/${userId}/links"; |
Comment on lines
+31
to
+34
| export interface ButtonGroupProps { | ||
| buttonList: ButtonData[] | undefined; | ||
| }; | ||
|
|
There was a problem hiding this comment.
타입 추가 좋습니다. 뒤에 undefined 값은 불필요해보입니다~
아래처럼 변경되면 좋겠어요.
export interface ButtonGroupProps {
buttonList: ButtonData[];
};
arthurkimdev
merged commit 37039a6
into
codeit-bootcamp-frontend:part2-김동현
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
코드리뷰 반영했습니다
셀프 코드 리뷰를 통해 질문 이어가겠습니다.