Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Dec 9, 2024
| values.tags.length > 0; | ||
|
|
||
| const handleChange = (name: string, value: any) => { | ||
| setValues((initialValues) => ({ |
There was a problem hiding this comment.
value를 업데이트 할때는 initialValues 보다는 prev나 prevState 같은 단어를 사용해주시는 것이 조금 더 직관적일 것 같습니다.
Comment on lines
+80
to
+91
| e.preventDefault(); | ||
| const formData = new FormData(); | ||
| formData.append("name", values.name); | ||
| formData.append("favorite", values.favoriteCount.toString()); | ||
| formData.append("description", values.description); | ||
| formData.append("price", values.price.toString()); | ||
| if (values.images) { | ||
| values.images.forEach((image, index) => { | ||
| formData.append(`images[${index}]`, image); | ||
| }); | ||
| } | ||
| formData.append("tags", JSON.stringify(values.tags)); |
There was a problem hiding this comment.
로직 간에 개행으로 구분해주시면 가독성에 도움이 될 것 같습니다.
There was a problem hiding this comment.
파일명에는 띄어쓰기를 공백으로 넣기보다는 _를 활용해서 표기하는 것을 추천드립니다.
| @@ -8,6 +8,7 @@ import heart from "@/public/svgs/ic_heart (1).svg"; | |||
| import defaultImage from "@/public/pngs/noImage.png"; | |||
| import searchIcon from "@/public/svgs/ic_search.svg"; | |||
| import { getArticles } from "@/lib/api"; | |||
| import debounce from "@/lib/utils/debounce"; | |||
There was a problem hiding this comment.
debounce 유틸 함수로 만들어주신거 좋네요.
| return 10; | ||
| } | ||
| }; | ||
| import getPageSize from "@/lib/utils/getPageSize"; | ||
|
|
||
| function AllItems() { | ||
| const [orderBy, setOrderBy] = useState<string>("recent"); |
There was a problem hiding this comment.
string 타입 대신에 들어가는 문자열을 타입으로 사용해보는 것은 어떨까요?
| ], | ||
| formats: ["image/avif", "image/webp"], |
| }; | ||
|
|
||
| export default function App({ Component, pageProps }: AppPropsWithLayout) { | ||
| const getLayout = |
Comment on lines
+37
to
+39
| const isLoginEnabled = (): boolean => { | ||
| return validateEmail(email) && password.length >= 8; | ||
| }; |
There was a problem hiding this comment.
이건 함수 말고 변수로 만들어도 될 것 같습니다.
There was a problem hiding this comment.
폼의 형식이 비슷해서 login에서 사용되는 함수들을 공통 훅으로 분리해서 같이 사용할 수 있게 만들어보셔도 좋을 것 같습니다.
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| background-color: #e6f2ff; |
jyh0521
reviewed
Dec 11, 2024
Comment on lines
+5
to
+10
| remotePatterns: [ | ||
| { | ||
| protocol: "https", | ||
| hostname: "**", | ||
| }, | ||
| ], |
There was a problem hiding this comment.
이것만 적용하면 밑에 domains는 없어도 되지 않나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게