[모수진] Sprint4 #69
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| const emailForm = document.getElementById("email"); | ||
| const pwdForm = document.getElementById("password"); | ||
|
|
||
|
|
||
|
|
||
| emailForm.addEventListener("focusout", (event) => { | ||
| var emailValue=emailForm.value; | ||
| if(emailValue == '') { | ||
| event.target.style.border='1px solid var(--red)'; | ||
| //todo: print error message | ||
| } | ||
| else { | ||
| event.target.style.border='0'; | ||
| } | ||
| }) | ||
| pwdForm.addEventListener("focusout",(event) => { | ||
| var pwdValue=pwdForm.value; | ||
| if(pwdValue == '') { | ||
| event.target.style.border='1px solid var(--red)'; | ||
| // todo: print error message | ||
| } | ||
| else if(pwdValue.length < 8 ) { | ||
| event.target.style.border='1px solid var(--red)'; //todo: print error message | ||
| } | ||
| else { | ||
| event.target.style.border='0'; | ||
| } | ||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| const emailForm = document.getElementById("email"); | ||
| const nickForm = document.getElementById("nickname"); | ||
| const pwdForm = document.getElementById("password"); | ||
| const pwdConfirmForm = document.getElementById("passwordConfirm"); | ||
|
|
||
|
There was a problem hiding this comment. 여기에서 button 도 불러와서 button 의 disabled 속성을 validate 에 따라 변경해주면 button 도 금방 disable 처리 할 수 있겠죠? |
||
|
|
||
| emailForm.addEventListener("focusout", (event) => { | ||
| var emailValue=emailForm.value; | ||
| if(emailValue == '') { | ||
| event.target.style.border='1px solid var(--red)'; | ||
| //todo: print error message | ||
| } | ||
| else { | ||
| event.target.style.border='0'; | ||
| } | ||
| }) | ||
| nickForm.addEventListener("focusout",(event) => { | ||
| var nickValue=nickForm.value; | ||
| if(nickValue == '') { | ||
| event.target.style.border='1px solid var(--red)'; | ||
| //todo: print error message | ||
| } | ||
| else { | ||
| event.target.style.border='0'; | ||
| } | ||
| }) | ||
| pwdForm.addEventListener("focusout",(event) => { | ||
| var pwdValue=pwdForm.value; | ||
| if(pwdValue == '') { | ||
| event.target.style.border='1px solid var(--red)'; | ||
| // todo: print error message | ||
| } | ||
| else if(pwdValue.length < 8 ) { | ||
| event.target.style.border='1px solid var(--red)'; //todo: print error message | ||
|
There was a problem hiding this comment. validate 구현 1) 이렇게 validate 가 실패했을때 보통 하단에 보이지 않는 div 등을 추가해주었다가, error 가 생기면 그때 diaplay 를 보여지도록 변경하고 에러 메시지를 content 를 넣어주고! 그런형태로 해보시면 됩니다 :) 안되면 멘토링시간에 한 번 더 질문해주세요! |
||
| } | ||
| else { | ||
| event.target.style.border='0'; | ||
| } | ||
| }) | ||
| pwdConfirmForm.addEventListener("focusout",(event) => { | ||
|
There was a problem hiding this comment. focus out 보다는 blur 를 더 많이 사용하는것 같아요! |
||
| var pwdValue=pwdForm.value; | ||
| var pwdConfirmValue=pwdConfirmForm.value; | ||
| if(pwdValue!=pwdConfirmValue) { | ||
| event.target.style.border='1px solid var(--red)'; | ||
| //todo: print error message | ||
| } | ||
| else { | ||
| event.target.style.border='0'; | ||
| } | ||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ body { | |
| padding:0px; | ||
| line-height: 26px; | ||
| } | ||
| .main-container { | ||
| margin:231px auto; | ||
| max-width:640px; | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ body { | |
| padding:0px; | ||
| line-height: 26px; | ||
| } | ||
| .main-container { | ||
| margin:60px auto; | ||
| max-width:640px; | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
login, signup 둘 다 focus out 일때 로직을 잘 작성해주셨어요!
하지만 항상 우리 form 의 꽃은 submit 입니다! 다음번에는 submit event 를 핸들링하는 함수를 꼭 작성해봅시다 :)