Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김창희] Sprint3 #49

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
2af9c62
chore: pull request template 파일 수정
changhui-chan Aug 19, 2024
0f4f673
chore: 중복 파일 제거
changhui-chan Aug 19, 2024
6d866d2
docs: pull request template 수정
changhui-chan Aug 19, 2024
4e54140
refactor: a 태그 li 태그 위치 수정
changhui-chan Aug 20, 2024
4549e3c
refactor: 컴포넌트 로드 기능을 별도의 파일로 분리
changhui-chan Aug 20, 2024
d404cfe
refactor: 일부 js 함수 콜백함수 분리 선언
changhui-chan Aug 20, 2024
f3b0451
refactor: 로그인 회원가입 페이지 버튼 기능 수정
changhui-chan Aug 20, 2024
bfd48a1
fix: 로그인 회원가입 페이지 로고 일부 수정
changhui-chan Aug 20, 2024
0fbc30b
style: 회원가입 로그인 페이지 여백 및 코드 공백 수정
changhui-chan Aug 20, 2024
dac1622
style: 변경가능성 없는 let 선언을 const 선언으로 변경
changhui-chan Aug 20, 2024
2945c98
refactor: css 반응형 제거
changhui-chan Aug 20, 2024
22fadd6
feat: 글로벌 css 반응형 작업 및 페이지별 반응형 css 파일 추가
changhui-chan Aug 20, 2024
b54c87d
feat: 메인 페이지 반응형 구현 및 일부 css 파일 삭제
changhui-chan Aug 20, 2024
f2e129a
fix: 헤더 잘못 적용된 여백 수정
changhui-chan Aug 21, 2024
b734bb7
fix: 메인 페이지 잘못 적용된 여백 수정 - 2
changhui-chan Aug 21, 2024
ade3f2e
feat: 로그인 페이지 반응형 구현
changhui-chan Aug 21, 2024
e7511a3
feat: 회원가입 페이지 반응형 구현
changhui-chan Aug 21, 2024
c6102c5
feat: OG태그 Twitter Card 태그 추가
changhui-chan Aug 21, 2024
0ec07b2
fix: 회원가입 css 파일 수정 및 패스워드 눈 아이콘 수정
changhui-chan Aug 21, 2024
7b3e144
fix: input 태그 outline 미적용 문제 해결
changhui-chan Aug 21, 2024
68c09e6
fix: 회원가입 로그인 input 속성 수정, 관련 코드 수정 및 추가
changhui-chan Aug 21, 2024
128796e
fix: 눈 아이콘 position 의도대로 수정 및 singup js 코드 오류 수정
changhui-chan Aug 21, 2024
e822329
feat: 로그인 회원가입 버튼 동작 시 조건 확인 후 링크 이동 기능 구현
changhui-chan Aug 21, 2024
afde7a6
style: 코드 공백 수정
changhui-chan Aug 22, 2024
d5f86d2
chore: ComponentCheckFunction.js 파일 JSDoc 추가
changhui-chan Aug 23, 2024
03f191c
chore: ComponentLoader.js 파일 JSDoc 추가
changhui-chan Aug 23, 2024
f0af555
chore: HtmlLoader.js 파일 JSDoc 추가
changhui-chan Aug 23, 2024
94ad89c
chore: LoginSignupUtils.js 파일 JSDoc 추가
changhui-chan Aug 23, 2024
9090e6e
refactor: LoginSignupUtils.js 파일 JSDoc 추가 및 리팩토링
changhui-chan Aug 23, 2024
8f92453
chore: CompoentCheckFunction.js 파일 JSDoc 수정
changhui-chan Aug 23, 2024
ac0256e
chore: LoginSignupUtils.js JSDoc 수정
changhui-chan Aug 23, 2024
fdeccc0
fix: meta 태그 description 부분 일부 수정
changhui-chan Aug 23, 2024
7ee3f91
fix: footer 여백 수정
changhui-chan Aug 23, 2024
3b78aea
fix: 이미지 파일 벡터 이미지로 변경 및 모바일 기준 width 오류 수정
changhui-chan Aug 23, 2024
1491dde
fix: 현재 안 쓰는 css 파일 삭제
changhui-chan Aug 23, 2024
44578b5
fix: 데스크탑 기준 메인 페이지 요소 여백 수정
changhui-chan Aug 23, 2024
8fc98b8
Revert "fix: footer 여백 수정"
changhui-chan Aug 23, 2024
e79ba6d
fix: 벡터 이미지 삽입에 따른 메인 페이지의 padding, margin, 기타 여백 수정
changhui-chan Aug 24, 2024
dca0c3c
fix: 회원가입 페이지 요소 크기 수정
changhui-chan Aug 24, 2024
f395e89
fix 로그인 페이지 모바일 max-width 수정
changhui-chan Aug 24, 2024
73d50f6
style: Signup.html 코드 여백 수정
changhui-chan Aug 24, 2024
6c368e9
style: Footer.html 코드 여백 수정
changhui-chan Aug 24, 2024
d234bea
style: Header.html 코드 여백 수정
changhui-chan Aug 24, 2024
4076e14
style: Home.html 코드 여백 수정
changhui-chan Aug 24, 2024
4b9b5c2
style: Login.html 코드 여백 수정
changhui-chan Aug 24, 2024
f481c07
style: Signup.js 코드 여백 수정
changhui-chan Aug 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 54 additions & 13 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,68 @@
## 요구사항

### 기본

- [x]
- []
- []
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]
- [x]


### 심화

- [x]
- []
- [x]
- [x]
- [x]
- [x]
- [x]

## 주요 변경사항

-
-
-
-
-
-
-
-
-
-
-
-

## 스크린샷

![image](이미지url)


## 배포 사이트



## 앞으로 수정해야할 사항

-
-
-
-
-

## 멘토에게

-
-
- 셀프 코드 리뷰를 통해 질문 이어가겠습니다.
-
-
-
-
-
-

Binary file removed assets/img/111.jpg
Binary file not shown.
Binary file removed assets/img/222.jpg
Binary file not shown.
Binary file removed assets/img/333.jpg
Binary file not shown.
Binary file removed assets/img/444.jpg
Binary file not shown.
Binary file removed assets/img/Img_home_01.png
Binary file not shown.
Binary file removed assets/img/Img_home_02-1.png
Binary file not shown.
Binary file removed assets/img/Img_home_03.png
Binary file not shown.
Binary file removed assets/img/Img_home_bottom.png
Binary file not shown.
Binary file removed assets/img/Img_home_top.png
Binary file not shown.
Binary file removed assets/img/Property 1=Typo.png
Binary file not shown.
Binary file removed assets/img/Property 1=lg.png
Binary file not shown.
Binary file removed assets/img/Property 1=md.png
Binary file not shown.
Binary file removed assets/img/Property 1=sm.png
Binary file not shown.
Binary file removed assets/img/ic_facebook.png
Binary file not shown.
Binary file removed assets/img/ic_instagram.png
Binary file not shown.
Binary file removed assets/img/ic_twitter.png
Binary file not shown.
Binary file removed assets/img/ic_youtube.png
Binary file not shown.
32 changes: 0 additions & 32 deletions assets/img/판다 얼굴.svg

This file was deleted.

17 changes: 0 additions & 17 deletions faq/index.html

This file was deleted.

19 changes: 17 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,33 @@
<title>판다마켓</title>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="description" content="판다마켓 구경오라이">
<meta name="description" content="일상의 모든 물건을 거래해보세요">

<meta property="og:title" content="판다 마켓">
<meta property="og:description" content="일상의 모든 물건을 거래해보세요">
<meta property="og:image" content="/src/assets/img/hamster1.jpg">
<meta property="og:url" content="https://panda-kuwan">
<meta property="og:type" content="website">
<meta property="og:site_name" content="판다 마켓">

<meta name="twitter:card" content="summary">
<meta name="twitter:title" content="판다 마켓">
<meta name="twitter:description" content="일상의 모든 물건을 거래해보세요">
<meta name="twitter:image" content="/src/assets/img/hamster1.jpg">
<meta name="twitter:site" content="@판다 마켓">

<link rel="icon" href="/src/assets/img/panda_head.svg">

<link rel="stylesheet" href="/src/styles/base.css">
<link rel="stylesheet" href="/src/styles/base-tablet.css">
<link rel="stylesheet" href="/src/styles/base-mobile.css">
</head>

<body>

<div data-include-html="/src/pages/home.html"></div>

<script src="/src/js/IncludeHtml.js"></script>
<script type="module" src="/src/js/HtmlLoader.js"></script>
</body>

</html>
17 changes: 0 additions & 17 deletions items/index.html

This file was deleted.

17 changes: 0 additions & 17 deletions login/index.html

This file was deleted.

17 changes: 0 additions & 17 deletions privacy/index.html

This file was deleted.

Binary file removed src/assets/img/Img_home_01.png
Binary file not shown.
Binary file removed src/assets/img/Img_home_02-1.png
Binary file not shown.
23 changes: 23 additions & 0 deletions src/assets/img/Img_home_02-1.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/assets/img/Img_home_03.png
Binary file not shown.
Binary file removed src/assets/img/Img_home_bottom.png
Binary file not shown.
Loading
Loading