-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[김희진] sprint3 #46
Merged
GANGYIKIM
merged 19 commits into
codeit-bootcamp-frontend:Basic-김희진
from
devmanta:Basic-김희진-sprint3
Aug 26, 2024
The head ref may contain hidden characters: "Basic-\uAE40\uD76C\uC9C4-sprint3"
+315
−108
Merged
[김희진] sprint3 #46
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0cfe633
refactor: further adjustments after code review
devmanta aded29c
refactor: remove index image width
devmanta 25f8897
refactor: merge index content description
devmanta 1675121
fix: restore btn-items
devmanta c279174
feat: add index hero tablet size css
devmanta 88d1109
refactor: merge index title
devmanta 11f628f
refactor: remove margin and add gap
devmanta 86dec28
feat: add index main content tablet size css
devmanta b6c7831
feat: add index bottom content tablet css
devmanta af0ab41
feat: modify footer justify content
devmanta 418ea33
feat: add index hero mobile css
devmanta 41d9ff3
feat: add botton and footer mobile css
devmanta 5723727
feat: add max-container on mobile size
devmanta 3720433
feat: add og tag
devmanta fe0dc50
fix: remove body 100vh on mobile size
devmanta 0cd84b4
refactor: add reset css and create login, signup directory
devmanta 3418966
chore: test git action
devmanta 8236985
chore: test git action
devmanta ed0f613
chore: git action
devmanta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,51 +16,19 @@ | |
--size-max-width: 1200px; | ||
} | ||
|
||
@font-face { | ||
font-family: 'ROKAF Sans'; /* 폰트 이름 정의 */ | ||
src: url('../fonts/ROKAF_Sans_Bold.ttf') format('truetype'); | ||
} | ||
Comment on lines
+19
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: |
||
|
||
* { | ||
box-sizing: border-box; | ||
GANGYIKIM marked this conversation as resolved.
Show resolved
Hide resolved
|
||
font-family: 'Pretendard', sans-serif; | ||
margin: 0; | ||
padding: 0; | ||
} | ||
|
||
header { | ||
position: fixed; | ||
top: 0; | ||
width: 100%; | ||
background-color: #fff; | ||
} | ||
|
||
body { | ||
margin: 0; | ||
padding: 0; | ||
height: 100vh; | ||
} | ||
|
||
a { | ||
text-decoration: none; | ||
} | ||
|
||
button { | ||
border: none; | ||
outline: none; | ||
cursor: pointer; | ||
} | ||
|
||
footer { | ||
background-color: var(--Secondary-900); | ||
width: 100%; | ||
} | ||
|
||
input { | ||
outline: none; | ||
border: none; | ||
} | ||
|
||
input:focus { | ||
outline: none; | ||
} | ||
|
||
input[type='submit'] { | ||
cursor: pointer; | ||
outline: none; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git action 실패해서 pr마다 다 x 쳐져있길래 거슬려서(?)
전적으로 GPT선생님 도움을 받아 branch 삭제 전에 branch 존재여부 확인하는 job 추가해보았습니다.
(실패사유가 브랜치를 못찾는거 같아서요..)
이게 정확히 맞는건진 잘 모르겠는데 일단 요 액션보면 Delete branch job은 동작하지 않은것으로 보여집니다🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도.. 깃헙 액션이 실패한것이 신경쓰였지만 흐린눈 하고 있었습니다
이렇게 고쳐보셨다니 좋네요.
PR close시랑 merge시 해당 스크립트가 실행되니 이따가 merge될때도 성공하면 좋겠네요.