Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[최순오]sprint 1 #18

Merged
merged 1 commit into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 168 additions & 0 deletions 10-Sprint-Mission/css/style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
body {

}
Comment on lines +1 to +3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2:
의미없는 빈 태그는 지워주세요.

Suggested change
body {
}


.header {
width: 1920px;
display: flex;
justify-content: space-between;
align-items: center;
height: 60px;
}

.header a img {
max-height: 100%;
margin-left: 360px;
margin-right: 360px;
Comment on lines +15 to +16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3:
아래도 동일하게 작동합니다.

Suggested change
margin-left: 360px;
margin-right: 360px;
margin: 0 360px; // 만약 중앙정렬을 하고 싶으신거라면 margin: 0 auto도 가능합니다.

}

.btn.top {
position: relative; /* 상대적인 위치 설정 */
top: -70px;
display: inline-block;
background-color: transparent;
padding: 0;
border: none;
font-size: 1.5rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1:
rem 같은 반응형 단위를 사용하실때는 html에 font-size 속성을 선언해주시는 것이 좋습니다.
rem은 root 폰트 사이즈 기반으로 계산되는 반응형 단위입니다. 이걸 적용해주지 않으면 해당 폰트가 어떤 것 기준으로 계산되는지 알 수 없습니다

font-weight: bold;

}

.itemlink {
cursor: pointer;
}

.top_banner {
width: 1920px;
position: relative;
background-color: #F0F8FF;
text-align: center;
padding: 20px 0;
}

.top_banner img {
max-width: 100%;
height: auto;
}

.main-container {

height: 2160px;
width: 1920px;
display: flex;
flex-direction: column;


}

h5 {
color: rgb(44, 67, 214);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

�P2:
rgb를 사용해야 할 이유가 없다면 hex code로 컬러값을 선언해주세요~

}

.main-item {
display: flex;
align-items: center;
justify-content: space-around; /* 이미지와 텍스트 같이 */
background-color: #f8f8f8; /* 각 섹션의 배경색 */
padding: 20px;
border-radius: 10px; /* 둥근 모서리 추가 */
}

.main-item.middle {
display: flex;
align-items: center;
justify-content: space-around; /* 이미지와 텍스트 같이 */
background-color: #f8f8f8; /* 각 섹션의 배경색 */
padding: 20px;
border-radius: 10px; /* 둥근 모서리 추가 */
}
Comment on lines +62 to +78
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3:
완전 동일한 속성이 두번 선언될 필요가 있을까요?
개발자의 의도가 궁금해지는 코드는 가독성 측면에서 좋지 않으니 가능하면
왜 이렇게 작성하셨는지 알 수 있도록 작성해주시면 좋겠습니다.

Suggested change
.main-item {
display: flex;
align-items: center;
justify-content: space-around; /* 이미지와 텍스트 같이 */
background-color: #f8f8f8; /* 각 섹션의 배경색 */
padding: 20px;
border-radius: 10px; /* 둥근 모서리 추가 */
}
.main-item.middle {
display: flex;
align-items: center;
justify-content: space-around; /* 이미지와 텍스트 같이 */
background-color: #f8f8f8; /* 각 섹션의 배경색 */
padding: 20px;
border-radius: 10px; /* 둥근 모서리 추가 */
}
// 차라리 이렇게..?
.main-item,
.main-item.middle {
display: flex;
align-items: center;
justify-content: space-around; /* 이미지와 텍스트 같이 */
background-color: #f8f8f8; /* 각 섹션의 배경색 */
padding: 20px;
border-radius: 10px; /* 둥근 모서리 추가 */
}


.image-container {
flex: 1;
text-align: center; /* 이미지를 가운데 정렬 */
margin-left: 360px;
}

.middle {
flex: 1;
text-align: center; /* 이미지를 가운데 정렬 */
margin-right: 360px 0;
}

.image-container img {
max-width: 100%;
height: auto;
margin: 100px;
}

.text-container {
flex: 1; /* 텍스트 영역을 이미지보다 크게 설정 */
text-align: left; /* 텍스트를 왼쪽 정렬 */
}
.text-container.middle {
flex: 1; /* 텍스트 영역을 이미지보다 크게 설정 */
text-align: right; /* 텍스트를 왼쪽 정렬 */
}

.text-container h2 {
font-size: 1.5rem;
margin-bottom: 10px;
}

p.focus {
font-size: 40px;
color: black;
}

p.focus.small {
font-size: 20px;
color: black;
}

.bottom_banner {
width: 1920px;
position: relative;
background-color: #F0F8FF;
text-align: center;
/* padding: 20px; */
}

.bottom_banner img {
/* max-width: 100%; */
height: auto;
}

.foot-container {
width: 1920px;
display: flex;
height: 160px;
justify-content: space-between;
align-items: center;
/* padding: 20px; */
background-color: #111827;
color: white;
}

.foot-left {
position: relative; /* 이렇게 밀어넣기 */
top: -50px;
right: -240px;
flex: 1; /*공간이 균등하게 배분된다는 듯*/
text-align: left;
}

.foot-center {
position: relative; /* 이렇게 밀어넣기 */
top: -50px;
flex: 1; /*공간이 균등하게 배분된다는 듯*/
text-align: center;
}

.foot-right {
position: relative; /* 이렇게 밀어넣기 */
top: -50px;
left: -240px;
flex: 1; /*공간이 균등하게 배분된다는 듯*/
text-align: right;
}

Binary file added 10-Sprint-Mission/img/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/Rectangle 1123.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/btn_small-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/btn_small-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/btn_small-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/btn_small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/state=active.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/state=click.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/state=hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/btn/state=inactive.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/gnb/standard=pc.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/Editor Icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/arrow_left.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/arrow_left/ic_back.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/arrow_right.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_X.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_arrow_down.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_check.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_heart.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_plus.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 10-Sprint-Mission/img/icons/ic_profile.png
Binary file added 10-Sprint-Mission/img/icons/ic_search.png
Binary file added 10-Sprint-Mission/img/icons/ic_search_darker.png
Binary file added 10-Sprint-Mission/img/icons/ic_sort.png
Binary file added 10-Sprint-Mission/img/icons/ic_twitter.png
Binary file added 10-Sprint-Mission/img/icons/ic_youtube.png
Binary file added 10-Sprint-Mission/img/icons/img_badge.png
Binary file added 10-Sprint-Mission/img/landing/desktop_01.png
Binary file added 10-Sprint-Mission/img/landing/desktop_02.png
Binary file added 10-Sprint-Mission/img/landing/desktop_03.png
Binary file added 10-Sprint-Mission/img/landing/desktop_04.png
Binary file added 10-Sprint-Mission/img/landing/desktop_05.png
Binary file added 10-Sprint-Mission/img/landing/mobile_01.png
Binary file added 10-Sprint-Mission/img/landing/mobile_02.png
Binary file added 10-Sprint-Mission/img/landing/mobile_03.png
Binary file added 10-Sprint-Mission/img/landing/mobile_04.png
Binary file added 10-Sprint-Mission/img/landing/mobile_05.png
Binary file added 10-Sprint-Mission/img/landing/tablet_01.png
Binary file added 10-Sprint-Mission/img/landing/tablet_02.png
Binary file added 10-Sprint-Mission/img/landing/tablet_03.png
Binary file added 10-Sprint-Mission/img/landing/tablet_04.png
Binary file added 10-Sprint-Mission/img/landing/tablet_05.png
Binary file added 10-Sprint-Mission/img/lg/Property 1=Typo.png
Binary file added 10-Sprint-Mission/img/lg/Property 1=lg.png
Binary file added 10-Sprint-Mission/img/lg/Property 1=md.png
Binary file added 10-Sprint-Mission/img/lg/Property 1=sm.png
Binary file added 10-Sprint-Mission/img/main/Img_home_01.png
Binary file added 10-Sprint-Mission/img/main/Img_home_02.png
Binary file added 10-Sprint-Mission/img/main/Img_home_03.png
87 changes: 87 additions & 0 deletions 10-Sprint-Mission/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2:

Suggested change
<html lang="en">
<html lang="ko">

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="./css/style.css">
<title>판다마켓</title>
</head>
<body>
<header class="header">
<a href="index.html">
<img src="./img/lg/Property 1=md.png" alt="로그인">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1:
이미지 명에 공백은 들어가지 않는 것이 좋습니다.
또한 어떤 이미지인지 알 수 있는 이름(logo.png)이면 좋을 것 같습니다.

Suggested change
<img src="./img/lg/Property 1=md.png" alt="로그인">
<img src="./img/logo.png" alt="판다마켓 로고">

</a>
<a href="./links/login.html">
<img src="./img/btn/btn_small.png" alt="로그인버튼">
</a>
</header>
<div>
<section class="top_banner">

<button class="btn top">
<p>일상의 모든 물건을 <br>거래해보세요</p>
<a href="./links/item.html">
<img class="itemlink" src="./img/btn/state=active.png" alt="구경하러가기">
</a>
</button>
Comment on lines +21 to +26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1:
button안에 a 태그가 들어가야할 이유가 있을까요?
페이지 이동을 시켜야하는 것이니 아래처럼 작성해도 될 것 같습니다.

Suggested change
<button class="btn top">
<p>일상의 모든 물건을 <br>거래해보세요</p>
<a href="./links/item.html">
<img class="itemlink" src="./img/btn/state=active.png" alt="구경하러가기">
</a>
</button>
<�div class="btn top">
<p>일상의 모든 물건을 <br>거래해보세요</p>
<a href="./links/item.html">
<img class="itemlink" src="./img/btn/state=active.png" alt="구경하러가기">
</a>
</div>

<img src="./img/Img_home_top.png" alt="배너">

</section>
</div>
<div>
<section class="main-container">
<section class="main-item">
<div class="image-container">
<img src="./img/main/Img_home_01.png" alt="상">
</div>
<div class="text-container">
<h5>Hot Item</h5>
<p class="focus">인기 상품을<br> 확인해 보세요</p>
<p class="focus small">가장 HOT한 중고거래 물품을<br> 팬다 마켓에서 확인해 보세요</p>
</div>
</section>
<section class="main-item middle">
<div class="text-container middle">
<h5>Search</h5>
<p class="focus">구매를 원하는<br> 상품을 검색하세요</p>
<p class="focus small">구매하고 싶은 물품은 검색해서<br> 쉽게 찾아보세요</p>
</div>
<div class="middle">
<img src="./img/main/Img_home_02.png" alt="중">
</div>
</section>

<section class="main-item">
<div class="image-container">
<img src="./img/main/Img_home_03.png" alt="하">
</div>
<div class="text-container">
<h5>Register</h5>
<p class="focus">판매를 원하는<br> 상품을 등록하세요</p>
<p class="focus small">어떤 물건이든 판매하고 싶은 상품을 쉽게 등록하세요</p>
</div>
</section>
</section>
</div>
<div>
<section class="bottom_banner">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2:
section이 너무 많이 사용되는 것 같습니다.
mdn의 section 페이지를 한번 읽어보시는 걸 추천드립니다.
Usage notes 부분에 스타일링을 위해서만이라면 div 태그를 추천드리고 있습니다.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section#usage_notes

<img src="./img/Img_home_bottom.png" alt="하단배너">
</section>
</div>
<footer class="foot">
<section class="foot-container">
<section class="foot-left">©codeit - 2024</section>
<section class="foot-center">
<a href="links/Privacy.html">Privacy Policy</a>
<a href="links/faq.html">FAQ</a>
</section>
<section class="foot-right">
<a href="https://www.facebook.com/"><img src="/img/icons/ic_facebook.png" alt="facebook"></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3:
외부영역으로 이동이 되는 경우는 새창으로 열어도 좋을 것 같습니다.

Suggested change
<a href="https://www.facebook.com/"><img src="/img/icons/ic_facebook.png" alt="facebook"></a>
<a href="https://www.facebook.com/" target='_blank'><img src="/img/icons/ic_facebook.png" alt="facebook"></a>

<a href="https://x.com/"><img src="/img/icons/ic_twitter.png" alt="twitter"></a>
<a href="https://www.youtube.com/"><img src="/img/icons/ic_youtube.png" alt="ic_youtube"></a>
<a href="https://www.instagram.com/"><img src="/img/icons/ic_instagram.png" alt="instagram"></a>
</section>
</section>
</footer>
</body>
</html>
11 changes: 11 additions & 0 deletions 10-Sprint-Mission/links/Privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>

</body>
</html>
11 changes: 11 additions & 0 deletions 10-Sprint-Mission/links/faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>

</body>
</html>
11 changes: 11 additions & 0 deletions 10-Sprint-Mission/links/item.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
item!!!
</body>
</html>
11 changes: 11 additions & 0 deletions 10-Sprint-Mission/links/login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>login</title>
</head>
<body>

</body>
</html>
Loading