-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[정성현] sprint10 #129
Merged
GANGYIKIM
merged 3 commits into
codeit-bootcamp-frontend:Next-정성현
from
jsh1147:Next-정성현-sprint10
Nov 5, 2024
The head ref may contain hidden characters: "Next-\uC815\uC131\uD604-sprint10"
Merged
[정성현] sprint10 #129
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { useContext } from "react"; | ||
import { MediaContext } from "@/store/MediaContext"; | ||
|
||
export function useMedia() { | ||
const media = useContext(MediaContext); | ||
return media; | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { createContext, useState, useEffect, ReactNode } from "react"; | ||
|
||
export type MediaType = "PC" | "TABLET" | "MOBILE"; | ||
|
||
export const MediaContext = createContext<MediaType | undefined>(undefined); | ||
|
||
interface MediaProviderProps { | ||
children: ReactNode; | ||
} | ||
|
||
export function MediaProvider({ children }: MediaProviderProps) { | ||
const [media, setMedia] = useState<MediaType>(); | ||
|
||
useEffect(() => { | ||
const checkMedia = (width: number): MediaType => { | ||
if (width >= 1200) return "PC"; | ||
if (width >= 768) return "TABLET"; | ||
return "MOBILE"; | ||
}; | ||
|
||
const handleWindowResize = () => { | ||
setMedia(checkMedia(window.innerWidth)); | ||
}; | ||
Comment on lines
+15
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: const checkMedia = (width: number): MediaType => {
if (width >= 1200) return "PC";
if (width >= 768) return "TABLET";
return "MOBILE";
};
const handleWindowResize = useCallback(() => {
setMedia(checkMedia(window.innerWidth));
}, []);
useEffect(() => {
handleWindowResize();
window.addEventListener("resize", handleWindowResize);
return () => {
window.removeEventListener("resize", handleWindowResize);
};
}, [handleWindowResize]); |
||
|
||
handleWindowResize(); | ||
|
||
window.addEventListener("resize", handleWindowResize); | ||
return () => { | ||
window.removeEventListener("resize", handleWindowResize); | ||
}; | ||
}, []); | ||
|
||
return ( | ||
<MediaContext.Provider value={media}>{children}</MediaContext.Provider> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,4 +44,7 @@ | |
--line-md: 24px; | ||
--line-sm: 22px; | ||
--line-xs: 18px; | ||
|
||
/* Font - Weight */ | ||
--semibold: 600; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
이건 분리하기보다 mediaContext 파일 하단에 같이 있는게 더 좋을 것 같아요.
이렇게 작업하기 위해서는 결국 mediaContext를 export 하게되서 구지 useMedia 라는 커스텀훅을 이용해서 접근하지 않을 수 있으니까요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context 관련해서 아래 블로그 글 한번 읽어보세요~
https://velog.io/@velopert/react-context-tutorial