Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stella-418
requested review from
JaeSang1998 and
GANGYIKIM
and removed request for
JaeSang1998
GANGYIKIM
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
가희님 이번 스프린트 미션 하시느라 고생하셨어요~
제가 작업중인 파일이라도 올려달라고 부탁드렸는데 들어주셔서 감사합니다
아직 UI 작업과 구조를 잡으시는 중이신 것 같고 올려주신 것들은
다 괜찮아서 피드백 드릴 것이 거의 없었네요~
다만 코드 공백이 좀 정리가 안된느낌이 있어서 prettier 같은 것을 쓰시면 어떨까싶습니다~
아래 링크를 참고해보세요~
https://velog.io/@gangk_99/VS-Code-Prettier-%EC%84%A4%EC%A0%95%ED%95%98%EA%B8%B0
| className={style.searchBar} | ||
| placeholder="검색할 상품을 입력해주세요" | ||
| ></input> | ||
| <button className={style.btnStyle}>상품 등록하기</button> |
There was a problem hiding this comment.
P2:
button 태그의 경우 type을 명시해주시는 것이 좋습니다~
Suggested change
| <button className={style.btnStyle}>상품 등록하기</button> | |
| <button type='button' className={style.btnStyle}>상품 등록하기</button> |
Comment on lines
+11
to
+14
| <input | ||
| className={style.searchBar} | ||
| placeholder="검색할 상품을 입력해주세요" | ||
| ></input> |
There was a problem hiding this comment.
P3:
children값이 없을 경우 아래처럼 하셔도 됩니다~
Suggested change
| <input | |
| className={style.searchBar} | |
| placeholder="검색할 상품을 입력해주세요" | |
| ></input> | |
| <input | |
| className={style.searchBar} | |
| placeholder="검색할 상품을 입력해주세요" | |
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게