-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[나승엽] Sprint2 #10
The head ref may contain hidden characters: "Basic-\uB098\uC2B9\uC5FD-Sprint1"
[나승엽] Sprint2 #10
Changes from all commits
fa826d7
63573de
268099f
550c9cd
0601bc3
a40b533
c6ecc0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 전반적으로 시멘틱 태그를 적절하게 잘 사용하셨네요. 👍 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<title>판다마켓</title> | ||
<link rel="stylesheet" href="스프린트미션.css" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 명확한 이유가 있는게 아니면 파일 명은 영문으로 사용해 주세요~ |
||
</head> | ||
<body> | ||
<header> | ||
<img src="Group 22.png" id="panda" /> | ||
<a href="index.html" id="pandamarket_p" | ||
><p id="pandamarket">판다마켓</p></a | ||
> | ||
Comment on lines
+11
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 로고 + 로고 텍스트 모두 링크가 걸려 있어야 할 것 같네요~! |
||
<a href="login.html"><div class="login">로그인</div></a> | ||
</header> | ||
<nav> | ||
<p>일상의 모든 물건을</p> | ||
<p>거래해보세요</p> | ||
<div class="visit"> | ||
<a href="/items" id="go"><span>구경하러 가기</span></a> | ||
</div> | ||
<img src="Img_home_top.png" id="nav_panda" /> | ||
</nav> | ||
Comment on lines
+17
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 네비게이션과 관련없는 영역에 해당 태그가 사용된 것 같네요. |
||
<main> | ||
<div class="main_container1"> | ||
<div class="item1"> | ||
<img src="Img_home_01.png" /> | ||
<div class="main_content1"> | ||
<p id="blue_p">Hot item</p> | ||
<p class="main_p">인기 상품을</p> | ||
|
||
<p class="main_p">확인해 보세요</p> | ||
|
||
<span id="main_span" | ||
>가장 HOT한 중고거래 물품을 판다 마켓에서 확인해 보세요</span | ||
> | ||
</div> | ||
</div> | ||
</div> | ||
Comment on lines
+26
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 각 섹션에 |
||
<div class="main_container2"> | ||
<div class="item2"> | ||
<img src="Img_home_02.png" /> | ||
<div class="main_content2"> | ||
<p id="blue_p2">Search</p> | ||
<p class="main_p2">구매를 원하는</p> | ||
<p class="main_p2">상품을 검색하세요</p> | ||
<span id="main_span2" | ||
>구매하고 싶은 물품은 검색해서 쉽게 찾아보세요</span | ||
> | ||
</div> | ||
</div> | ||
</div> | ||
<div class="main_container3"> | ||
<div class="item3"> | ||
<img src="Img_home_03.png" /> | ||
<div class="main_content3"> | ||
<p id="blue_p3">Register</p> | ||
<p class="main_p3">판매를 원하는</p> | ||
<p class="main_p3">상품을 등록하세요</p> | ||
<span id="main_span3" | ||
>어떤 물건이든 판매하고 싶은 상품을 쉽게 등록하세요</span | ||
> | ||
</div> | ||
</div> | ||
</div> | ||
</main> | ||
<div id="tail_banner"> | ||
<img src="Img_home_bottom.png" id="tail_panda" /> | ||
<p class="tail_p">믿을 수 있는</p> | ||
<p class="tail_p">판다마켓 중고 거래</p> | ||
</div> | ||
<footer> | ||
<div class="footer_box"> | ||
<p class="footer_p">©codeit - 2024</p> | ||
<a href="/privacy" class="footer_link">Privacy Policy</a> | ||
<a href="/faq" class="footer_link">FAQ</a> | ||
<a href="https://www.facebook.com" target="_blank"> | ||
<img src="ic_facebook (1).png" /> | ||
</a> | ||
<a href="https://www.twitter.com" target="_blank"> | ||
<img src="ic_twitter.png" /> | ||
</a> | ||
<a href="https://www.youtube.com" target="_blank"> | ||
<img src="ic_youtube.png" /> | ||
</a> | ||
<a href="https://www.instagram.com" target="_blank"> | ||
<img src="ic_instagram.png" /> | ||
Comment on lines
+76
to
+88
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이미지만 있는 버튼 또는 링크 요소는 유의미한 대체 텍스트 제공해주세요~! |
||
</a> | ||
</div> | ||
</footer> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<title>로그인</title> | ||
<link rel="stylesheet" href="로그인&회원가입.css" /> | ||
</head> | ||
<body id="body"> | ||
<header id="main_header"> | ||
<img src="판다 얼굴.png" /> | ||
<a href="index.html" id="a_tag"> | ||
<p>판다마켓</p> | ||
</a> | ||
</header> | ||
<main id="content"> | ||
<label class="label">이메일</label> | ||
<input type="email" class="input" placeholder="이메일을 입력해주세요" /> | ||
<label class="label">비밀번호</label> | ||
<input | ||
type="password" | ||
class="input" | ||
placeholder="비밀번호를 입력해주세요" | ||
/> | ||
Comment on lines
+19
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 각 필드의 브라우저가 제공하는 접근성을 충분히 활용하시려면 다음 중 하나를 선택하여 반영해 주시면 더 좋을 것 같네요~!
|
||
<div id="login_box">로그인</div> | ||
<div id="nav_footer_box"> | ||
<p id="nav_footer_p"><b>간편 로그인하기</b></p> | ||
<div id="easy_login"> | ||
<a href="https://www.google.com/"><img src="google.png" /></a | ||
><a href="https://www.kakaocorp.com/page/" | ||
><img src="cacaotalk.png" | ||
/></a> | ||
</div> | ||
</div> | ||
</main> | ||
<footer id="footer"> | ||
판다마켓이 처음이신가요? <a href="sign_up.html" id="gaip">회원가입</a> | ||
</footer> | ||
</body> | ||
</html> |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reset CSS 잘 적용하셨습니다! 👍 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,124 @@ | ||
html, | ||
body, | ||
div, | ||
span, | ||
applet, | ||
object, | ||
iframe, | ||
h1, | ||
h2, | ||
h3, | ||
h4, | ||
h5, | ||
h6, | ||
p, | ||
blockquote, | ||
pre, | ||
a, | ||
abbr, | ||
acronym, | ||
address, | ||
big, | ||
cite, | ||
code, | ||
del, | ||
dfn, | ||
em, | ||
img, | ||
ins, | ||
kbd, | ||
q, | ||
s, | ||
samp, | ||
small, | ||
strike, | ||
strong, | ||
sub, | ||
sup, | ||
tt, | ||
var, | ||
b, | ||
u, | ||
i, | ||
center, | ||
dl, | ||
dt, | ||
dd, | ||
ol, | ||
ul, | ||
li, | ||
fieldset, | ||
form, | ||
label, | ||
legend, | ||
table, | ||
caption, | ||
tbody, | ||
tfoot, | ||
thead, | ||
tr, | ||
th, | ||
td, | ||
article, | ||
aside, | ||
canvas, | ||
details, | ||
embed, | ||
figure, | ||
figcaption, | ||
footer, | ||
header, | ||
hgroup, | ||
menu, | ||
nav, | ||
output, | ||
ruby, | ||
section, | ||
summary, | ||
time, | ||
mark, | ||
audio, | ||
video { | ||
margin: 0; | ||
padding: 0; | ||
border: 0; | ||
font-size: 100%; | ||
font: inherit; | ||
vertical-align: baseline; | ||
} | ||
/* HTML5 display-role reset for older browsers */ | ||
article, | ||
aside, | ||
details, | ||
figcaption, | ||
figure, | ||
footer, | ||
header, | ||
hgroup, | ||
menu, | ||
nav, | ||
section { | ||
display: block; | ||
} | ||
body { | ||
line-height: 1; | ||
} | ||
ol, | ||
ul { | ||
list-style: none; | ||
} | ||
blockquote, | ||
q { | ||
quotes: none; | ||
} | ||
blockquote:before, | ||
blockquote:after, | ||
q:before, | ||
q:after { | ||
content: ""; | ||
content: none; | ||
} | ||
table { | ||
border-collapse: collapse; | ||
border-spacing: 0; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<title>회원가입</title> | ||
<link rel="stylesheet" href="로그인&회원가입.css" /> | ||
</head> | ||
<body id="body"> | ||
<header id="main_header"> | ||
<img src="판다 얼굴.png" /> | ||
<a href="index.html" id="a_tag"> | ||
<p>판다마켓</p> | ||
</a> | ||
</header> | ||
<main id="content"> | ||
<label class="label">이메일</label> | ||
<input type="email" class="input" placeholder="이메일을 입력해주세요" /> | ||
<label class="label">닉네임</label> | ||
<input type="text" class="input" placeholder="닉네임을 입력해주세요" /> | ||
<label class="label">비밀번호</label> | ||
<input | ||
type="password" | ||
class="input" | ||
placeholder="비밀번호를 입력해주세요" | ||
/> | ||
<label class="label">비밀번호 확인</label> | ||
<input | ||
type="password" | ||
class="input" | ||
placeholder="비밀번호를 다시 한 번 입력해주세요" | ||
/> | ||
<div id="login_box">회원가입</div> | ||
<div id="nav_footer_box"> | ||
<p id="nav_footer_p"><b>간편 로그인하기</b></p> | ||
<div id="easy_login"> | ||
<a href="https://www.google.com/"><img src="google.png" /></a | ||
><a href="https://www.kakaocorp.com/page/" | ||
><img src="cacaotalk.png" | ||
/></a> | ||
</div> | ||
</div> | ||
</main> | ||
<footer id="footer"> | ||
판다마켓이 처음이신가요? <a href="login.html" id="gaip">로그인</a> | ||
</footer> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
벡터 이미지로 표현할 수 있는 아이콘, 로고 이미지 등은 SVG 확장자로 사용해 주세요!