fix: errors on GA

codeigniter4 · Aug 22, 2024 · 36698fc · 36698fc
1 parent 218b3b1
commit 36698fc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/system/Commands/Utilities/PhpIniCheck.php b/system/Commands/Utilities/PhpIniCheck.php
@@ -80,7 +80,7 @@ public function run(array $params)
             return EXIT_ERROR;
         }
 
-        $argument = isset($params[0]) && $params[0] ? $params[0] : null;
+        $argument = $params[0] ?? null;
 
         CheckPhpIni::run(argument: $argument);
 

diff --git a/tests/system/Commands/Utilities/PhpIniCheckTest.php b/tests/system/Commands/Utilities/PhpIniCheckTest.php
@@ -15,7 +15,6 @@
 
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\StreamFilterTrait;
-use Config\App;
 use PHPUnit\Framework\Attributes\Group;
 
 /**
@@ -38,7 +37,7 @@ protected function tearDown(): void
         parent::tearDown();
     }
 
-    protected function getBuffer()
+    protected function getBuffer(): string
     {
         return $this->getStreamFilterBuffer();
     }
@@ -60,7 +59,7 @@ public function testCommandCheckOpcache(): void
     {
         command('phpini:check opcache');
 
-        $this->assertStringContainsString("opcache.save_comments", $this->getBuffer());
+        $this->assertStringContainsString('opcache.save_comments', $this->getBuffer());
     }
 
     public function testCommandCheckNoExistsArg(): void