For Windows OS, revert the usage of cmd.exe by default (new option)

[axel3rd]

This PR is an update of old previous staling PR #42

---

cf. #17 (comments from May 2018): Revert the usage of cmd.exe by default (on Windows), because prevents the destroy/kill launched by this way when CTRL+C.

Allow this behavior by the usage of a new method:

Commandline cmd = new Commandline();
cmd.setForceShellOsSpecific( true );

---

This PR should be chosen or #109.

[axel3rd]

Note: GitHub action verify problem with Java 16-ea is not part of this PR.

[axel3rd]

(@michael-o: Requested changes have been done)

[axel3rd]

Note: GitHub action verify problem with Java 16-ea is not part of this PR.

See #116

[axel3rd]

Is this PR (or #109) not relevant 😢 ?

[michael-o]

I will try to pick this up next month.

[axel3rd]

Thank you !

[axel3rd]

I will try to pick this up next month.

😁 (#FriendlyBump)

[michael-o]

Thanks for the note. I think both Bourne Shell and Cmd Shell must go. There is no use for that.

[axel3rd]

I think both Bourne Shell and Cmd Shell must go. There is no use for that

=> We abandon this PR, and perhaps #109 depending the relevance ?

[michael-o]

I first need to understand why this was done at all. Maybe lack of knowledge. Currently, I don't see a reason why we should wrap these command into a shell execution at all.

[rfscholte]

From what I've always understood only with a new shell you can isolate system properties and environment variables.

[michael-o]

System properties are pure args to a process. There is no connection to the parent process. If want to isolate env vars, you can do that easily with the ProcessBuilder. It works just fine. Moreover, you cannot start with a nude environment because some processes expect default env vars and they won't be present. Just set those you need and that's it.