Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serviceAccountJsonSecretKeyRef for gcedisk #470

Merged
merged 6 commits into from
Jun 9, 2024

Conversation

mikhail-klimko
Copy link
Collaborator

@mikhail-klimko mikhail-klimko commented Jun 9, 2024

What

Fix typo in secret volume (dind-volume-provisioner) when gcedisk is enabled.
Update README for gcedisk.
Fix google-service-account.json key in volume-provisioner secret template.

Why

Notes

@mikhail-klimko mikhail-klimko marked this pull request as ready for review June 9, 2024 10:56
@mikhail-klimko mikhail-klimko requested a review from a team as a code owner June 9, 2024 10:56
@mikhail-klimko mikhail-klimko merged commit 7e7a66a into release-1.0 Jun 9, 2024
2 checks passed
@mikhail-klimko mikhail-klimko deleted the fix/gce-disks branch June 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants