Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage class spec for azure disk #425

Merged
merged 2 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/cf-runtime/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: A Helm chart for Codefresh Runner
name: cf-runtime
version: 6.3.2
version: 6.3.3
keywords:
- codefresh
- runner
Expand All @@ -15,7 +15,7 @@ maintainers:
annotations:
artifacthub.io/changes: |
- kind: fixed
description: Exclude inactive memory from memory metrics
description: Fix storage class template for Azure Disk storage backend
dependencies:
- name: cf-common
repository: oci://quay.io/codefresh/charts
Expand Down
16 changes: 14 additions & 2 deletions charts/cf-runtime/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Codefresh Runner

![Version: 6.3.2](https://img.shields.io/badge/Version-6.3.2-informational?style=flat-square)
![Version: 6.3.3](https://img.shields.io/badge/Version-6.3.3-informational?style=flat-square)

Helm chart for deploying [Codefresh Runner](https://codefresh.io/docs/docs/installation/codefresh-runner/) to Kubernetes.

Expand Down Expand Up @@ -419,13 +419,25 @@ Deploy Helm chart with the following values:

`values.yaml`
```yaml
volumeProvisioner:
podSecurityContext:
enabled: true
runAsUser: 0
runAsGroup: 0
fsGroup: 0

storage:
backend: azuredisk
azuredisk:
location: westcentralus
availabilityZone: northeurope-1 # replace with your zone
resourceGroup: my-resource-group-name

mountAzureJson: true

runtime:
dind:
nodeSelector:
topology.kubernetes.io/zone: northeurope-1
```

### Custom global environment variables
Expand Down
14 changes: 13 additions & 1 deletion charts/cf-runtime/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -419,13 +419,25 @@ Deploy Helm chart with the following values:

`values.yaml`
```yaml
volumeProvisioner:
podSecurityContext:
enabled: true
runAsUser: 0
runAsGroup: 0
fsGroup: 0

storage:
backend: azuredisk
azuredisk:
location: westcentralus
availabilityZone: northeurope-1 # replace with your zone
resourceGroup: my-resource-group-name

mountAzureJson: true

runtime:
dind:
nodeSelector:
topology.kubernetes.io/zone: northeurope-1
```


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ parameters:
skuName: {{ .Values.storage.azuredisk.skuName | default "Premium_LRS" }}
fsType: {{ .Values.storage.fsType | default "ext4" }}
cachingMode: {{ .Values.storage.azuredisk.cachingMode | default "None" }}
{{- with .Values.storage.azuredisk.location }}
location: {{ . | quote }}
{{- with .Values.storage.azuredisk.availabilityZone }}
availabilityZone: {{ . | quote }}
{{- end }}
{{- with .Values.storage.azuredisk.resourceGroup }}
resourceGroup: {{ . | quote }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ tests:
- it: Test volume-provisioner with azure disks
set:
storage.backend: azuredisk
storage.azuredisk.location: somewhere
storage.azuredisk.availabilityZone: somewhere
storage.azuredisk.resourceGroup: some-rg
storage.mountAzureJson: true
asserts:
Expand Down Expand Up @@ -405,7 +405,7 @@ tests:
value: azuredisk
template: templates/volume-provisioner/storageclass.yaml
- equal:
path: parameters.location
path: parameters.availabilityZone
value: somewhere
template: templates/volume-provisioner/storageclass.yaml
- equal:
Expand Down
2 changes: 1 addition & 1 deletion charts/cf-runtime/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ storage:
# -- Set storage type (`Premium_LRS`)
skuName: Premium_LRS
cachingMode: None
# location: westcentralus
# availabilityZone: northeurope-1
# resourceGroup:
# DiskIOPSReadWrite: 500
# DiskMBpsReadWrite: 100
Expand Down