fix(engine): exclude inactive memory from memory metrics #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
mikhail-klimko
approved these changes
Nov 22, 2023
ghost
deleted the
CR-21247-exclude-inactive-memory-from-memory-metrics
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This upgrades engine to v1.168.0 which contains a fix for build memory metrics.
Exact formula depends on Control Group and Docker API versions:
cgroup v1:
memoryUsage = memory_stats.usage - memory_stats.stats.total_inactive_filecgroup v2:
memoryUsage = memory_stats.usage - memory_stats.stats.inactive_fileunknown cgroup (older Docker API):
memoryUsage = memory_stats.usage - memory_stats.stats.cacheWhy
Bug fix.
Notes
—